Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2534039pxb; Mon, 18 Jan 2021 22:35:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJwh7n0xICZiyICCLPOavR0q4Fnafbwo78Vka4bWlFlMl/ged9+JZVdzTuz2gz1aDdCrDQ6l X-Received: by 2002:a17:906:97cb:: with SMTP id ef11mr1993657ejb.379.1611038105783; Mon, 18 Jan 2021 22:35:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611038105; cv=none; d=google.com; s=arc-20160816; b=oZjZFdqnHgb7V8uB25+RsUv71sVQGGOMqBe6iCNoMpEJ2dzcFHbEsJcDJsZer4qdVw dI6h3XUxy4SF1c6U6EPBQdOoCQAecsoc+c4COBLiRuS9C7gywR5sc/3GvzprVN42jGgD fwuAcf6bf7FAj9hDk6j1xYCkqdjsUA5hEJ4GIQ2f5v8R0OMd7z8TQVc/+FynztzzWECl DNh4/ukDr5zciXQfQdXictc1RWzvaiE/8in1bsZpcdxFUtd5gDjvoGspqQc6JFzDtwH6 0f6H17zKMXCnGu+o1N5iG6Hd5KaeOortLuQDRyL8WRJ8kXePVDOWlt+Ys7/jCBDCfi5o 7xQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=0o0+TgvaCWGMYtqMzcwzh04u4T4qz6KJkNsE1jebPxI=; b=b/Kbxd1hrkSq8FsSpQ68k+hS8LijRVkQlyHp9tml2BzDam24BYG/tLk9YM55etqxnQ UfjyRAUrs0TQqYZpUXvOEX8ZF9RcZ7b2i8NNMBtPvDchcbExry2vTg8CnUfzMvnz0ueq pYzc7QFqO+9q/HcqhYu9Zd07hgrGrkY7E6jgADSKqG0fQwzgkdxh1d9/1FkRUG5+slv6 1iGXS45TBiZS/Y3HYnzHY5nuIo8b3+jBm+ihmSrKphKJVOA58CPFcx/jAGXjwgDSIGFa A95Eq2+T/T+fOvqNi+w9x05PJBjQR37rv0beaASmifrS6ZaRL6wOQPiPheW76R2pnnBa bC3A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a11si7416956eje.119.2021.01.18.22.34.38; Mon, 18 Jan 2021 22:35:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727459AbhASGdm (ORCPT + 99 others); Tue, 19 Jan 2021 01:33:42 -0500 Received: from out30-43.freemail.mail.aliyun.com ([115.124.30.43]:59595 "EHLO out30-43.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727860AbhASGdi (ORCPT ); Tue, 19 Jan 2021 01:33:38 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R351e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04357;MF=abaci-bugfix@linux.alibaba.com;NM=1;PH=DS;RN=10;SR=0;TI=SMTPD_---0UMDPCxf_1611037957; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:abaci-bugfix@linux.alibaba.com fp:SMTPD_---0UMDPCxf_1611037957) by smtp.aliyun-inc.com(127.0.0.1); Tue, 19 Jan 2021 14:32:41 +0800 From: Jiapeng Zhong To: pkshih@realtek.com Cc: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org, Larry.Finger@lwfinger.net, chiu@endlessos.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Zhong Subject: [PATCH v2] rtlwifi: rtl8192se: Simplify bool comparison. Date: Tue, 19 Jan 2021 14:32:35 +0800 Message-Id: <1611037955-105333-1-git-send-email-abaci-bugfix@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fix the follow coccicheck warnings: ./drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:2305:6-27: WARNING: Comparison of 0/1 to bool variable. ./drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:1376:5-26: WARNING: Comparison of 0/1 to bool variable. Reported-by: Abaci Robot Signed-off-by: Jiapeng Zhong --- Changes in v2: -Modified subject. drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c index 47fabce..aff8ab0 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c @@ -1373,7 +1373,7 @@ static void _rtl92se_gen_refreshledstate(struct ieee80211_hw *hw) struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw)); struct rtl_led *pled0 = &rtlpriv->ledctl.sw_led0; - if (rtlpci->up_first_time == 1) + if (rtlpci->up_first_time) return; if (rtlpriv->psc.rfoff_reason == RF_CHANGE_BY_IPS) @@ -2302,7 +2302,7 @@ bool rtl92se_gpio_radio_on_off_checking(struct ieee80211_hw *hw, u8 *valid) bool turnonbypowerdomain = false; /* just 8191se can check gpio before firstup, 92c/92d have fixed it */ - if ((rtlpci->up_first_time == 1) || (rtlpci->being_init_adapter)) + if (rtlpci->up_first_time || rtlpci->being_init_adapter) return false; if (ppsc->swrf_processing) -- 1.8.3.1