Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp178524pxb; Thu, 21 Jan 2021 04:38:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJyysKAIUYqjc146VA7/s4VhbtK1SDmhxlNcaoKUBTZACAIIb4azHZTCwlYQwgJO3sQl8fCF X-Received: by 2002:a50:8b66:: with SMTP id l93mr10557916edl.384.1611232680635; Thu, 21 Jan 2021 04:38:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611232680; cv=none; d=google.com; s=arc-20160816; b=iTrCxe+ONEdbJE5gHzYSTTXkiAlQUUPx3O/zZJIwhGCEjvCXiAXch4xKHgA6Rhl39l iWAST+cVzJjZBVghagZv/UDTuqW9OLMOMCli5sp4Apy4bBC85DhhRbubS8EIXmRcAzvq 63Tv6A3fkkq1cDu045JjjKAJ7ZjWlM2HkSuOWdFmLHoZN4zZwUO1kxwf+5roSLljYiE+ 4wbHP7ka2pEA4ZZLdFbDOfpmJhd+jHArewzwUGjZWTbqVZ2ShfSQq9oQxWoDop8+tsi/ vrHugIEFtVyEeYXGywdgXRBwXGzZ2CYxA+uKNoBrcxyIw6E4Ms0M6nD3MOWXQ3VqarYZ cUGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=YRyKCqFVgw2A9kzG+3RRr2cTWJOvUgHN7sGk6iJ7Qoo=; b=R5RNJ360mvmk146LkRAYjosJ6cghRq1llRGTcm/Tsd5zlht3HwkAYOadgnYZtSrEjl j9QF3Lik6yrq+hWw+hO8ivRkJn7Q8BWTKK8UhpVxwtCXhp4wgrNrEse6uSU3F0srkKQQ JjUbNwlvmSnyluY+wiZPsXi9YA3UH1dL30OoHJO7KCbpO0UXh8AvYS8BqSXIPTov83g1 j7NMxJla1Qp5Z+N26b54UYy7Ge5tbOblUcgh4sDXee/22AGIvhmub52E1qFuwJTvWVnP JIo4cQPvbYXW6WWP0Lirzt5C5Y2O06UsMXOPjJ1cFOZWXUMVP9f8MnqsV+HXqWytPWqT HhLA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t5si1713996ejy.497.2021.01.21.04.37.36; Thu, 21 Jan 2021 04:38:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727100AbhAUMfB (ORCPT + 99 others); Thu, 21 Jan 2021 07:35:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731346AbhAUMdd (ORCPT ); Thu, 21 Jan 2021 07:33:33 -0500 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98E24C061575 for ; Thu, 21 Jan 2021 04:32:52 -0800 (PST) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1l2Z8s-009XIP-Sx; Thu, 21 Jan 2021 13:32:50 +0100 Message-ID: <92dcf0de488a7b72280a20fb9c01fe6c99f8f96b.camel@sipsolutions.net> Subject: Re: [PATCH v2] mac80211: enable QoS support for nl80211 ctrl port From: Johannes Berg To: Markus Theil Cc: linux-wireless@vger.kernel.org Date: Thu, 21 Jan 2021 13:32:50 +0100 In-Reply-To: <20201212104826.5868-1-markus.theil@tu-ilmenau.de> References: <20201212104826.5868-1-markus.theil@tu-ilmenau.de> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Hi, Seems reasonable to me, all in all, but > @@ -3934,7 +3932,8 @@ void __ieee80211_subif_start_xmit(struct sk_buff *skb, > if (IS_ERR(sta)) > sta = NULL; > > - if (local->ops->wake_tx_queue) { > + if (local->ops->wake_tx_queue || > + skb->protocol == sdata->control_port_protocol) { > u16 queue = __ieee80211_select_queue(sdata, sta, skb); > skb_set_queue_mapping(skb, queue); > skb_get_hash(skb); I don't understand this part. Why not do the necessary setup in ieee80211_tx_control_port(), instead of potentially overwriting it for EAPOL-over-AF_PACKET frames here? johannes