Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <92dcf0de488a7b72280a20fb9c01fe6c99f8f96b.camel@sipsolutions.net>
Subject: Re: [PATCH v2] mac80211: enable QoS support for nl80211 ctrl port
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Markus Theil <markus.theil@tu-ilmenau.de>
Cc:     linux-wireless@vger.kernel.org
Date:   Thu, 21 Jan 2021 13:32:50 +0100
In-Reply-To: <20201212104826.5868-1-markus.theil@tu-ilmenau.de>
References: <20201212104826.5868-1-markus.theil@tu-ilmenau.de>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

Seems reasonable to me, all in all, but

> @@ -3934,7 +3932,8 @@ void __ieee80211_subif_start_xmit(struct sk_buff *skb,
>  	if (IS_ERR(sta))
>  		sta = NULL;
> 
> -	if (local->ops->wake_tx_queue) {
> +	if (local->ops->wake_tx_queue ||
> +	    skb->protocol == sdata->control_port_protocol) {
>  		u16 queue = __ieee80211_select_queue(sdata, sta, skb);
>  		skb_set_queue_mapping(skb, queue);
>  		skb_get_hash(skb);

I don't understand this part.

Why not do the necessary setup in ieee80211_tx_control_port(), instead
of potentially overwriting it for EAPOL-over-AF_PACKET frames here?

johannes