Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1397713pxb; Fri, 22 Jan 2021 15:01:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJysyIzYkV1TLrxDvpzvRGkk+j9GcPfNHwnRJcVwpyYaceor8sD08A+KVcjclS2N2U3L+xOL X-Received: by 2002:a17:906:f18c:: with SMTP id gs12mr4549336ejb.422.1611356496806; Fri, 22 Jan 2021 15:01:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611356496; cv=none; d=google.com; s=arc-20160816; b=myCXy/IXYwwIxxw5pTFruTY4RF5yAGAeQn/bb/2x7vGTWyk2mwPbHFen1xTfFErMtP che5KpFU6F0Jg5805uhg8Kik9Gx5+RkqgbFwnZjZl3UmNsNBkv09abyMt6ol7XdIFgmR kNg6zmug86BGcAglYOxtOHxBkoIBB/CXQnRwLuMxs1VD5mZ9y78vWuQXSGLeNzPfq1PD h0MKt92kSI+iyrjuLmCrphOhnFzLoqBQ+PN51Hb/yjgIPg6bNeJEnSVogNgu/1GYwC99 wiKgpkDBuqHqMsUZtBe7eh/Ganhd4CsGgjV7vBeu/5sCMa0qUYVZPrWn+Abv1CCnKz2A 8XxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=dIFHFPrKW7JpzLF/A1gkPwmI3yVQYT3DCosEgoesovY=; b=rKcEj9wCOgsVwLWzRLhBeagN8VXa9G3k00z82Eo/hwl/BSzp1u6/V3mTmawaQanV6H ty3eP5fYpsQqIlXxBb/0g5gPwSCUlkL0taX2JysKyq6GPjiBURzXfubf8NvwUBLXaU78 8UTrFehhNWCj75qaLKuWrsB+zyQJLMYT932PXzoIUd5z2RApUDkFy0NrQ8D/38MMyIEz zbSD55snAOZK1OmKnV2NXWGtyWrFj/R2i34IJInEq4exLPkBC/UxUaKquwhOcC3tr6ii QeOeeFNZ+1NwL8fcXhGx6PhtEaNGc/4pBhbRe4lBP94kXjFpOfVolNdi9KJyD3maMuiT Ba/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=G71XFS8J; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x22si4136798edl.459.2021.01.22.15.01.12; Fri, 22 Jan 2021 15:01:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=G71XFS8J; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728987AbhAVXAr (ORCPT + 99 others); Fri, 22 Jan 2021 18:00:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728525AbhAVXAg (ORCPT ); Fri, 22 Jan 2021 18:00:36 -0500 Received: from mail-oi1-x235.google.com (mail-oi1-x235.google.com [IPv6:2607:f8b0:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B982C06174A for ; Fri, 22 Jan 2021 14:59:56 -0800 (PST) Received: by mail-oi1-x235.google.com with SMTP id q205so7785461oig.13 for ; Fri, 22 Jan 2021 14:59:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dIFHFPrKW7JpzLF/A1gkPwmI3yVQYT3DCosEgoesovY=; b=G71XFS8JNXxCwO7BXCPstGBCRP88249JZCwORgWKdY9+UnIrXiPhIJ+3tt3Xag4LMO w8B8XHQ1AFhElanql23zRZLuZxWO34QeGWIkVoB8CiNHKoFfxTwDW4u2fnUyELU9jRGz E8awpEb5z6YZSQTWN6m2PUb2ZReQKaJGDDCAY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dIFHFPrKW7JpzLF/A1gkPwmI3yVQYT3DCosEgoesovY=; b=so4stiMmCIr82+7UxMiJYClA9cSqE+4MkKjsJoLcr9RbupeH33MmGUkpP5lvU+ZEix C7tDOwFdzxvXbpQ+/f5cER65dPX+eSYMYlJpL5BWDrTknqsBFNdH9Uprw7uwTt+enWbr fNO+J0sPEIG2r8E5vbAiz9wFDAIRRNwHN+31rC1zc6oNi1hJ9/p/NH4EWwWL1tw+KFXn 5+DbLu0RpHzNp43PcIDWq5maeGp5QyygsrVD9+T4Mhp4/8Dovha6Df1aUefklx/t9yJe ecw9iRYKXYLNx4jox2iSffvD+5vvBB+ZE8kxl/AdnszjJALe1eIrhjy7TxGhcIGUYahk KUjg== X-Gm-Message-State: AOAM531KBvWlGknS5kldBUaGf/SvJAWwL2rfloZmXMyDtLd5uI7vDpPO HKS/+yILPd3umyRRbjg4QEzItPoDFk60tQ== X-Received: by 2002:aca:af58:: with SMTP id y85mr4751497oie.33.1611356395598; Fri, 22 Jan 2021 14:59:55 -0800 (PST) Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com. [209.85.167.181]) by smtp.gmail.com with ESMTPSA id r204sm2040650oif.0.2021.01.22.14.59.54 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Jan 2021 14:59:54 -0800 (PST) Received: by mail-oi1-f181.google.com with SMTP id w124so7847688oia.6 for ; Fri, 22 Jan 2021 14:59:54 -0800 (PST) X-Received: by 2002:aca:f40c:: with SMTP id s12mr4653465oih.105.1611356394174; Fri, 22 Jan 2021 14:59:54 -0800 (PST) MIME-Version: 1.0 References: <20210115092405.8081-1-pkshih@realtek.com> <20210115092405.8081-5-pkshih@realtek.com> In-Reply-To: <20210115092405.8081-5-pkshih@realtek.com> From: Brian Norris Date: Fri, 22 Jan 2021 14:59:42 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 4/8] rtw88: replace tx tasklet with work queue To: Ping-Ke Shih Cc: Yan-Hsuan Chuang , Kalle Valo , linux-wireless , phhuang@realtek.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Fri, Jan 15, 2021 at 1:26 AM Ping-Ke Shih wrote: > > From: Po-Hao Huang > > Replace tasklet so we can do tx scheduling in parallel. Since throughput > is delay-sensitive in most cases, we allocate a dedicated, high priority > wq for our needs. > > Signed-off-by: Po-Hao Huang > Signed-off-by: Ping-Ke Shih For this (and the rest of the series, minus comments on patch 3): Reviewed-by: Brian Norris