Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2032816pxb; Sat, 23 Jan 2021 14:22:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJwXyc9BcVxupXTrswBjpitWyCW5sKg1C9jZDc182yIDrDeGAW64/ErDuLigclRxX4F8G+8q X-Received: by 2002:a50:8004:: with SMTP id 4mr254953eda.155.1611440548937; Sat, 23 Jan 2021 14:22:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611440548; cv=none; d=google.com; s=arc-20160816; b=i53cQz0xFnJWWsYE5XxjNq2eFgeAhmMbjjVTK3ORvP4W2CogU5BbwZjNdUhIKbmNcb iBzRYSD2xAud3fmRXhDeyGrWPcQOMdvP/ic9tDyZSTBeUxAALGKEErxE3GYGwnp+67pM OFZ1ssvP6zKVGLv7D2zlltMPX+ZyozU6ZsElwdv/XKehQehbTBTDzne7zYfmtwCHoTGy PdUask+v7tjNECWp6HQn0oHeg1ZYD+tCqh9ahelf0QI8dLjhYN7Hl4tlfW2xgA8c8fRr +JuFoX/fclH7PYfWwVSJyye6VtbHAk4uHyoozEwd8KBGQXQ1sE57x3T8N0svcFOkkHB5 Sv0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=ZpaE085AyPdgXZRVgAjH8PniivoTTD/eSKGcQo6hbYc=; b=Ee2OypWARPZpJBb1FLqy8t1bOz0whTZbKI+HzJKxJEyGHcVONxh0A+N9ex3+mIGMFE PUGH1BMrhDwzp70gZFUSW/rlYlgqQnSp/lYrkXqWgLtv7rM1IVxKnt6kl2UGfLDGRqe9 wqHpgim+f9oOjBqjNYvX/aeO5JN0zBoYjx4OeUjHVEWVPgJdsksYdNRDQ4nXdDaUzHxT u7jgw2YJS37yb1H4sjdxJV4FZhgE4rrgofEWARAwmDcEoor/tutVRxxH7h1D9GssHX2E ln77X0Kj2lJ+OQy/X1jFLHpw+iOix53rODJhOEge3+vNrEXM3qiIMXBaPU7khnq3YdI6 Z1+g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jg15si4398604ejc.481.2021.01.23.14.21.40; Sat, 23 Jan 2021 14:22:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726197AbhAWWQh (ORCPT + 99 others); Sat, 23 Jan 2021 17:16:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725765AbhAWWQg (ORCPT ); Sat, 23 Jan 2021 17:16:36 -0500 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77641C0613D6; Sat, 23 Jan 2021 14:15:56 -0800 (PST) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1l3RCB-00Aicf-K9; Sat, 23 Jan 2021 23:15:51 +0100 Message-ID: Subject: Re: pull-request: mac80211 2021-01-18.2 From: Johannes Berg To: Hans de Goede , netdev@vger.kernel.org Cc: linux-wireless@vger.kernel.org, ilan.peer@intel.com, luciano.coelho@intel.com Date: Sat, 23 Jan 2021 23:15:50 +0100 In-Reply-To: <77c606d4-a78a-1fa3-5937-b270c3d0bbd3@redhat.com> References: <20210118204750.7243-1-johannes@sipsolutions.net> <77c606d4-a78a-1fa3-5937-b270c3d0bbd3@redhat.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Sat, 2021-01-23 at 22:31 +0100, Hans de Goede wrote: > > So I'm afraid that I have some bad news about this patch, it fixes > the RCU warning which I reported: > > https://lore.kernel.org/linux-wireless/20210104170713.66956-1-hdegoede@redhat.com/ > > But it introduces a deadlock. See: > > https://lore.kernel.org/linux-wireless/d839ab62-e4bc-56f0-d861-f172bf19c4b3@redhat.com/ > > for details. Note we really should fix this new deadlock before 5.11 > is released. This is worse then the RCU warning which this patch fixes. Ouch. Thanks for the heads-up. I guess I'll revert both patches for now, unless we can quickly figure out a way to get all these paths in order. Thanks, johannes