Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org AA44DC433CA
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] iwl4965: do not process non-QOS frames on
 txq->sched_retry
 path
From:   Kalle Valo <kvalo@codeaurora.org>
In-Reply-To: <20210119100621.439134-1-stf_xl@wp.pl>
References: <20210119100621.439134-1-stf_xl@wp.pl>
To:     stf_xl@wp.pl
Cc:     linux-wireless@vger.kernel.org,
        Dan Carpenter <dan.carpenter@oracle.com>
User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2
Message-Id: <20210125144400.49273C43461@smtp.codeaurora.org>
Date:   Mon, 25 Jan 2021 14:44:00 +0000 (UTC)
Precedence: bulk

stf_xl@wp.pl wrote:

> From: Stanislaw Gruszka <stf_xl@wp.pl>
> 
> We have already WARN_ON(!qc) for non-QOS frame on txq->sched_retry path,
> but we continue to process, what makes no sense since tid is not
> initialized. Non QOS frame should never happen when aggregation
> is enabled on queue, so do not process that.
> 
> Patch should fix smatch warning:
> drivers/net/wireless/intel/iwlegacy/4965-mac.c:2822 il4965_hdl_tx() error: uninitialized symbol 'tid'.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Stanislaw Gruszka <stf_xl@wp.pl>

Patch applied to wireless-drivers-next.git, thanks.

4832bb371c41 iwl4965: do not process non-QOS frames on txq->sched_retry path

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20210119100621.439134-1-stf_xl@wp.pl/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches