Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3296528pxb; Mon, 25 Jan 2021 11:58:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJw5sqGma8tOW3xRfL2kroBo257LGAMVAw4FiC/r3/MqYomRZKnUCueQ1qm+kVSUQwBexjlR X-Received: by 2002:a17:907:948d:: with SMTP id dm13mr1305124ejc.545.1611604706593; Mon, 25 Jan 2021 11:58:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611604706; cv=none; d=google.com; s=arc-20160816; b=WdwflyYntAhvokkmf1oRUyGwwXum6bcMxANG/8b6AO6rRj1SZhkWnTwCWYdvw3rLwX KrLU8MFSP7H+9TQaMTpP9N1lnG2BCSqbRQdyeoIM8o3vu56ng+KL3Hu0z0N/OQzgnm7Y 13k7USSVSy3sOezFiyXbdqvC2+/SV0xwJqdDZi4X41Uxr7WSGUuanT1SCzFnYHDAzCnP XAnwvlMa7APVNZxOINU2OyEEvlxe5X/UEJDbA4Tarj0pQWaL/RYtyr4h+YcBfQFYwYer 9fB0oVKPhjsy14jEFr4BjEQGWnZnQDhi9O+AYt/imOl+AJqTZq93jUB2Ue2v3dyp4+4Q 90mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=+G3tbsa73pLLQzUd7H7JxP/D88BKWNVKZcVB8Ud6hZ8=; b=NJXqQfvm5Imo3/IoV3aMD40Uu6goGUsQxBX9axc8Qowjbip+baB31OkS9q9PfYdaQ+ BXAeRd8lcd/abB6Fb01Huu3jiTSQwgMFFkw9F84v/Bu7C4oiZE5ARZvTvkMDlsKxK0Uc vck/aU+rdDEnXzg02tMUSJtDD+gdT7p23qWMj430l7VzTKIzywobfMleevgiZxmAQOye IsjQ+esgVFKs2lO1bjJA6X5h06DY05nU+4oFMelkFlCY82BGYn9K5nblzCOG0EvG+c7P TSNXgzzA3ZI8mb8Y7CCnkTz1Bzq+ygeedUk3PZCZoo74LeZFq5iyyDO7DWG2817Apiid u2GA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dg6si7569490edb.485.2021.01.25.11.57.50; Mon, 25 Jan 2021 11:58:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732148AbhAYTwt (ORCPT + 99 others); Mon, 25 Jan 2021 14:52:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732155AbhAYTwi (ORCPT ); Mon, 25 Jan 2021 14:52:38 -0500 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02E80C06174A for ; Mon, 25 Jan 2021 11:51:57 -0800 (PST) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1l47ty-00BYIp-JB; Mon, 25 Jan 2021 20:51:54 +0100 Message-ID: <2027106c42a27eb850217eaae928b7d36e345f4c.camel@sipsolutions.net> Subject: Re: [PATCHv2] cfg80211: Skip key deletion for open associations From: Johannes Berg To: chaitanya.mgit@gmail.com, linux-wireless@vger.kernel.org Cc: Chaitanya Tata Date: Mon, 25 Jan 2021 20:51:53 +0100 In-Reply-To: <20210125192046.975-1-chaitanya.mgit@gmail.com> (sfid-20210125_202058_832502_8683DD33) References: <20210125192046.975-1-chaitanya.mgit@gmail.com> (sfid-20210125_202058_832502_8683DD33) Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, 2021-01-26 at 00:50 +0530, chaitanya.mgit@gmail.com wrote: > From: Chaitanya Tata > > From: Chaitanya Tata That's broken, please check your git mail setup. > * Delete all the keys ... pairwise keys can't really > * exist any more anyway, but default keys might. > */ > - if (rdev->ops->del_key) { > + if (wdev->connect_keys && rdev->ops->del_key) { > This is wrong, wdev->connect_keys is not needed to make a secure connection. johannes