Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210125192046.975-1-chaitanya.mgit@gmail.com> <2027106c42a27eb850217eaae928b7d36e345f4c.camel@sipsolutions.net>
In-Reply-To: <2027106c42a27eb850217eaae928b7d36e345f4c.camel@sipsolutions.net>
From:   Krishna Chaitanya <chaitanya.mgit@gmail.com>
Date:   Tue, 26 Jan 2021 01:37:27 +0530
Message-ID: <CABPxzYK7jPKbCokST-DMCyvoF_gqhWnBGZvUfgqZTfjeN-X2Ng@mail.gmail.com>
Subject: Re: [PATCHv2] cfg80211: Skip key deletion for open associations
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     linux-wireless <linux-wireless@vger.kernel.org>,
        Chaitanya Tata <chaitanya.tata@bluwireless.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jan 26, 2021 at 1:21 AM Johannes Berg <johannes@sipsolutions.net> wrote:
>
> On Tue, 2021-01-26 at 00:50 +0530, chaitanya.mgit@gmail.com wrote:
> > From: Chaitanya Tata <chaitanya.mgit@gmail.com>
> >
> > From: Chaitanya Tata <chaitanya.mgit@gmail.com>
>
> That's broken, please check your git mail setup.
Fixed.
>
>
> >        * Delete all the keys ... pairwise keys can't really
> >        * exist any more anyway, but default keys might.
> >        */
> > -     if (rdev->ops->del_key) {
> > +     if (wdev->connect_keys && rdev->ops->del_key) {
> >
>
> This is wrong, wdev->connect_keys is not needed to make a secure
> connection.
Ah, I guess it's only for the WEP, right? From a quick look, we are not saving
connect params (connect.crypto), will take a deeper look, thanks.