Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: pull-request: mac80211 2021-01-18.2
To:     Johannes Berg <johannes@sipsolutions.net>,
        "Peer, Ilan" <ilan.peer@intel.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc:     "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "Coelho, Luciano" <luciano.coelho@intel.com>
References: <20210118204750.7243-1-johannes@sipsolutions.net>
 <77c606d4-a78a-1fa3-5937-b270c3d0bbd3@redhat.com>
 <b83f6cf001c4e3df97eeaed710b34fda0a08265f.camel@sipsolutions.net>
 <BN7PR11MB2610052E380E676ED5CCCC67E9BE9@BN7PR11MB2610.namprd11.prod.outlook.com>
 <348210d8-6940-ca8d-e3b1-f049330a2087@redhat.com>
 <666b3449fe33d34123255cc69da3aa46fc276dcb.camel@sipsolutions.net>
From:   Hans de Goede <hdegoede@redhat.com>
Message-ID: <6c949dbe-5593-2274-7099-c2768b770aad@redhat.com>
Date:   Mon, 25 Jan 2021 12:18:41 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.0
MIME-Version: 1.0
In-Reply-To: <666b3449fe33d34123255cc69da3aa46fc276dcb.camel@sipsolutions.net>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 1/25/21 10:47 AM, Johannes Berg wrote:
> Hi,
> 
> Sorry, apparently we have two threads.
> 
>> Great, thank you for looking into this. Let me know if you have a patch
>> which you want me to test on a RTL8723BS adapter.
> 
> Could you test this instead?
> 
> https://p.sipsolutions.net/235c352b8ae5db88.txt
> 
> 
> I don't have that much sympathy for a staging driver that's clearly
> doing things differently than it was intended (the documentation states
> that the function should be called only before wiphy_register(), not
> during ndo_open). :-)

I completely understand and I already was worried that this might be
a staging-driver issue, which is why I mentioned this was with a
staging driver in the more detailed bug-report email.

> But OTOH, that fix to the driver is simple and looks correct to me since
> it only ever has a static regdomain, and the notifier does the work of
> applying it to the channels as well.

So I've given your fix a quick try and it leads to a NULL pointer deref.

But now that you've given me a lead on how to fix this (network/wifi
drivers are not really me expertise) I can take a shot at seeing if I
can fix the NULL pointer deref. I Hope to get back to you on that later
today.

Regards,

Hans