Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: periyasa=codeaurora.org@mg.codeaurora.org
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Wed, 27 Jan 2021 08:16:32 +0530
From:   Karthikeyan periyasamy <periyasa@codeaurora.org>
To:     Peter Oh <peter.oh@eero.com>
Cc:     ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath11k: Update tx descriptor search index properly
In-Reply-To: <959ea12a-e35b-5867-c55e-7f62e2956b09@eero.com>
References: <1608305041-21946-1-git-send-email-periyasa@codeaurora.org>
 <959ea12a-e35b-5867-c55e-7f62e2956b09@eero.com>
Message-ID: <d6cbfd2aff787faa3be69252b2677df9@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Precedence: bulk

On 2020-12-19 00:53, Peter Oh wrote:
> On 12/18/20 7:24 AM, Karthikeyan Periyasamy wrote:
>> Tx descriptor search index field should be updated with hw peer id
>> and not by AST Hash. Incorrect search index causes throughput 
>> degradation
>> in all the platforms. so updated the search index field with hw peer 
>> id,
>> which is a common change applicable for all the platforms.
>> 
>> Tested-on: IPQ8074 hw2.0 AHB 
>> WLAN.HK.2.4.0.1-01492-QCAHKSWPL_SILICONZ-1
>> 
>> diff --git a/drivers/net/wireless/ath/ath11k/peer.c 
>> b/drivers/net/wireless/ath/ath11k/peer.c
>> index b69e7eb..f49abefa 100644
>> --- a/drivers/net/wireless/ath/ath11k/peer.c
>> +++ b/drivers/net/wireless/ath/ath11k/peer.c
>> 
>> @@ -309,7 +310,11 @@ int ath11k_peer_create(struct ath11k *ar, struct 
>> ath11k_vif *arvif,
>>     	peer->pdev_idx = ar->pdev_idx;
>>   	peer->sta = sta;
>> -	arvif->ast_hash = peer->ast_hash;
>> +
>> +	if (arvif->vif->type == NL80211_IFTYPE_STATION) {
>> +		arvif->ast_hash = peer->ast_hash;
>> +		arvif->ast_idx = peer->hw_peer_id;
>> +	}
> 
> How about non STATION type?
> 

no need of configuring the ast_idx, ast_hash field for non station type. 
Its recommended by HW/FW team.

Thanks,
Karthikeyan P