Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp60904pxb; Wed, 27 Jan 2021 01:58:38 -0800 (PST) X-Google-Smtp-Source: ABdhPJxCWCleqR72EyFubrc8xgkmxFxNKHJWCtjxzpgfpmnPr2Pyxvb7AaKVb7dtCoVsLbL//Xz0 X-Received: by 2002:a50:eacd:: with SMTP id u13mr8126780edp.382.1611741518703; Wed, 27 Jan 2021 01:58:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611741518; cv=none; d=google.com; s=arc-20160816; b=WCVi8s+b2yLDwj2aYsDft5NnLaGjPL1UxiJrMPN63a9Eb3c50gIw4JqEU8tromqK+U N/6jr5EQIOOHQJC6zKq/IyVCbalqmOfrthFsdeoux5oe1e0DA0oUQAMH16YPI3mvd5vC 1m6c7iVDVvupufpVowh7Hz9qfqwiRdRC0/NYVdRcx8nPZxfi8at/kBLZiu1SdwXtI0r1 ZjbcLSOb3u6ePvZmoUTFPtMMvNwb0crl4C7u+QBoQPThLNJSGkpEFz+JvhcfG/N3ObpI mZE3QH/AWpqkVz8uR4tgAX2PbRXunhF9SYb9p6zsxPVu+RJEudHP8K3Q2rdHCXvCtyd5 7kcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=wwbNAMlyyNqPKG+kg2efgbjKjGibjXVAmVLGYyJE+ak=; b=SyVntamXbO+wL6coeyAijF9bUGAMNqyZrZ9NlDifnlMfKuGjKs6d84eE7luSYl50lA f+YDPu7BiIZ04I/G2UxBMGWTBSNCyN4phMPMILyl6zQneOlF9Gs99yAGIdXM7Igra4w4 Ntq5SRYY2M/Mcg9IwoAWAjQxVMm0cppiNBw/TmzzjUy7xLYQsjyYxPTeGHIOeAFuNkQv PU4rLlw+d0wybZzzptrTHFS/bDhlG5YMKxXdAJ/IhNbyHCFhec3Bl5YfOfMAxGH4B/Z9 K5xeC2Co0d/icNFEIuZhuqEblqg9jE/JcEbZblfMUymGcoymi9pTRQyqrs/gOdWtW8q6 OYSQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p8si699662edm.503.2021.01.27.01.58.09; Wed, 27 Jan 2021 01:58:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235573AbhA0J4I (ORCPT + 99 others); Wed, 27 Jan 2021 04:56:08 -0500 Received: from out30-54.freemail.mail.aliyun.com ([115.124.30.54]:46890 "EHLO out30-54.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232989AbhA0Jx6 (ORCPT ); Wed, 27 Jan 2021 04:53:58 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R451e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=alimailimapcm10staff010182156082;MF=abaci-bugfix@linux.alibaba.com;NM=1;PH=DS;RN=10;SR=0;TI=SMTPD_---0UN1fMSF_1611741191; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:abaci-bugfix@linux.alibaba.com fp:SMTPD_---0UN1fMSF_1611741191) by smtp.aliyun-inc.com(127.0.0.1); Wed, 27 Jan 2021 17:53:15 +0800 From: Abaci Team To: pkshih@realtek.com Cc: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org, Larry.Finger@lwfinger.net, lee.jones@linaro.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Abaci Team Subject: [PATCH] rtlwifi: halbtc8723b2ant: Remove redundant code Date: Wed, 27 Jan 2021 17:53:09 +0800 Message-Id: <1611741189-45892-1-git-send-email-abaci-bugfix@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fix the following coccicheck warnings: ./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c: 1876:11-13: WARNING: possible condition with no effect (if == else). Reported-by: Abaci Robot Suggested-by: Jiapeng Zhong Signed-off-by: Abaci Team --- .../realtek/rtlwifi/btcoexist/halbtc8723b2ant.c | 22 ---------------------- 1 file changed, 22 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c index 7a71f06..ef2c3eb 100644 --- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c +++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c @@ -1273,8 +1273,6 @@ static void btc8723b2ant_ps_tdma(struct btc_coexist *btcoexist, bool force_exec, } else { if (coex_sta->a2dp_bit_pool >= 45) wifi_duration_adjust = -15; - else if (coex_sta->a2dp_bit_pool >= 35) - wifi_duration_adjust = -10; else wifi_duration_adjust = -10; } @@ -1805,11 +1803,6 @@ static void btc8723b2ant_tdma_duration_adjust(struct btc_coexist *btcoexist, NORMAL_EXEC, true, 14); coex_dm->ps_tdma_du_adj_type = 14; - } else if (max_interval == 3) { - btc8723b2ant_ps_tdma(btcoexist, - NORMAL_EXEC, - true, 15); - coex_dm->ps_tdma_du_adj_type = 15; } else { btc8723b2ant_ps_tdma(btcoexist, NORMAL_EXEC, @@ -1827,11 +1820,6 @@ static void btc8723b2ant_tdma_duration_adjust(struct btc_coexist *btcoexist, NORMAL_EXEC, true, 10); coex_dm->ps_tdma_du_adj_type = 10; - } else if (max_interval == 3) { - btc8723b2ant_ps_tdma(btcoexist, - NORMAL_EXEC, - true, 11); - coex_dm->ps_tdma_du_adj_type = 11; } else { btc8723b2ant_ps_tdma(btcoexist, NORMAL_EXEC, @@ -1851,11 +1839,6 @@ static void btc8723b2ant_tdma_duration_adjust(struct btc_coexist *btcoexist, NORMAL_EXEC, true, 6); coex_dm->ps_tdma_du_adj_type = 6; - } else if (max_interval == 3) { - btc8723b2ant_ps_tdma(btcoexist, - NORMAL_EXEC, - true, 7); - coex_dm->ps_tdma_du_adj_type = 7; } else { btc8723b2ant_ps_tdma(btcoexist, NORMAL_EXEC, @@ -1873,11 +1856,6 @@ static void btc8723b2ant_tdma_duration_adjust(struct btc_coexist *btcoexist, NORMAL_EXEC, true, 2); coex_dm->ps_tdma_du_adj_type = 2; - } else if (max_interval == 3) { - btc8723b2ant_ps_tdma(btcoexist, - NORMAL_EXEC, - true, 3); - coex_dm->ps_tdma_du_adj_type = 3; } else { btc8723b2ant_ps_tdma(btcoexist, NORMAL_EXEC, -- 1.8.3.1