Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp829438pxb; Thu, 28 Jan 2021 00:53:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJyIiXMCcuBN26/RrFkWay5K91yybLCipiYUS1M26WicwXBW9HafkH5aQXRYXihMX93B/t0d X-Received: by 2002:a05:6402:1c0f:: with SMTP id ck15mr12525979edb.171.1611824002775; Thu, 28 Jan 2021 00:53:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611824002; cv=none; d=google.com; s=arc-20160816; b=X1wzTkMzAGeeymZZGR+gJWBJ/MAbfozhuFL6N3rybEsX+QqzXBHamQXYdFZ6yaDGYV W5O2fE2VP8gOA0B0SmJ8OjSB1F2tE4a7fDZxUmGi5UMvFVKjp9usOjr3xLdhjRey7zUP OQMhHXBgv4WodEQeUw91LjZ8i4CszLkUAfvmTlAT1fRj5doL09x1/OsyG4X75eCKpy/V ohaGBIKxANf31kauodR5mbGu7zIJtzcdG0N5mxjsQmJ/Pb2Z9Na6tSzVr533jvIgKSTq bVA9JqzmxeP3QsH1abaBdw9HCjN4e5SZJs5aIiWUmn4NzSoStshkj4G6EkVJTuDz2P5s G4Cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=84MnG7I1i1e8KmUfWyCsEhKqPbBdEmOTyv0sS3fMGcM=; b=LuIDrnkzU5i6us31AfbZIm2EGK2j0k80uUAOfEsbXwYovA7ukvJfawLn6ixbJb9ACx hsWqZ/TSBPLr4Iq4Y10zOEUdSlvoxLMrBzoeM9hMeuIvuuGszT826OnlTqbabl96ROb4 n2PDlkmEuwpyC01QPa6RGJXzhPiZMrfrX2NC+moHvJtExA5OcSbVFHFEva2QbG3W19E/ Otko4lr5J07DZlYuDa3ANkb1ZooGWqKFbdcNfzDrRX/v3UmetlfnbfG/b/HUoY5CPqMt EZ2K4WDPWIOZaBmvgvvz5WMvNHrOt2VaOzLJXnDQftc/xFmGKu8zOT62bCpf4BkThDDp MK+g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h8si2288639ejj.71.2021.01.28.00.52.57; Thu, 28 Jan 2021 00:53:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231770AbhA1IrR (ORCPT + 99 others); Thu, 28 Jan 2021 03:47:17 -0500 Received: from out30-45.freemail.mail.aliyun.com ([115.124.30.45]:40571 "EHLO out30-45.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232086AbhA1Iqv (ORCPT ); Thu, 28 Jan 2021 03:46:51 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R121e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04394;MF=abaci-bugfix@linux.alibaba.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---0UN7ZE16_1611823637; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:abaci-bugfix@linux.alibaba.com fp:SMTPD_---0UN7ZE16_1611823637) by smtp.aliyun-inc.com(127.0.0.1); Thu, 28 Jan 2021 16:47:21 +0800 From: Abaci Team To: kvalo@codeaurora.org Cc: davem@davemloft.net, kuba@kernel.org, linux-wireless@vger.kernel.org, lee.jones@linaro.org, b43-dev@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Abaci Team Subject: [PATCH] b43: Remove redundant code Date: Thu, 28 Jan 2021 16:47:16 +0800 Message-Id: <1611823636-18377-1-git-send-email-abaci-bugfix@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fix the following coccicheck warnings: ./drivers/net/wireless/broadcom/b43/phy_n.c:4640:2-4: WARNING: possible condition with no effect (if == else). ./drivers/net/wireless/broadcom/b43/phy_n.c:4606:2-4: WARNING: possible condition with no effect (if == else). Reported-by: Abaci Robot Suggested-by: Jiapeng Zhong Signed-off-by: Abaci Team --- drivers/net/wireless/broadcom/b43/phy_n.c | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/drivers/net/wireless/broadcom/b43/phy_n.c b/drivers/net/wireless/broadcom/b43/phy_n.c index b669dff..39a335f 100644 --- a/drivers/net/wireless/broadcom/b43/phy_n.c +++ b/drivers/net/wireless/broadcom/b43/phy_n.c @@ -4601,16 +4601,6 @@ static void b43_nphy_spur_workaround(struct b43_wldev *dev) if (nphy->hang_avoid) b43_nphy_stay_in_carrier_search(dev, 1); - if (nphy->gband_spurwar_en) { - /* TODO: N PHY Adjust Analog Pfbw (7) */ - if (channel == 11 && b43_is_40mhz(dev)) { - ; /* TODO: N PHY Adjust Min Noise Var(2, tone, noise)*/ - } else { - ; /* TODO: N PHY Adjust Min Noise Var(0, NULL, NULL)*/ - } - /* TODO: N PHY Adjust CRS Min Power (0x1E) */ - } - if (nphy->aband_spurwar_en) { if (channel == 54) { tone[0] = 0x20; @@ -4636,12 +4626,6 @@ static void b43_nphy_spur_workaround(struct b43_wldev *dev) tone[0] = 0; noise[0] = 0; } - - if (!tone[0] && !noise[0]) { - ; /* TODO: N PHY Adjust Min Noise Var(1, tone, noise)*/ - } else { - ; /* TODO: N PHY Adjust Min Noise Var(0, NULL, NULL)*/ - } } if (nphy->hang_avoid) -- 1.8.3.1