Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1224109pxb; Thu, 28 Jan 2021 10:48:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJyTQFVOTX7QbIhQ9qqN5475NgCvIpMthn5ZexW/GbMgF4Ocl2/MQq7CICVaSbhne2gE3BHV X-Received: by 2002:a17:907:3f13:: with SMTP id hq19mr852355ejc.142.1611859732567; Thu, 28 Jan 2021 10:48:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611859732; cv=none; d=google.com; s=arc-20160816; b=F7KQvuMOMZUz/3NgHBhvdgQ+6XcG4fESfmyDYKKIgAbf4/xcNFObhvJUWipZZcsOu2 jJwM2igm2yMt30x/bYPLK8ZmILVEUSCvV/R1OM8WeyjZcUjN2Y0bJsfLP3+kSP7oXEDh w34KBQWsPhOLDBAhRWQNdjmX7D0RTcmrfMQMG5MPMyP0KnyUX3mTI4g+Jn6ybYcydDWZ hCVmAQ7Ggc5ktOzPJufcrMQ1gBEU2H7CSu+4msGBg6e0im5rax/wx0RDyU8JTe2xm8y7 uKwSg0xZCIwa9zq2MmP4mP3Uhu8z8Mn+b5evsP6CDZ6yz6PP7Zu29r/UQojAeasrIP1c HV0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=7KqrQELa5Ib7c8yGtm34ctZRTTgOgBVXw/XDTJkuZzM=; b=E8RaFxmscrc7bFG+HJyctDSf6Je9qlqcIhzD2A7XrcYwPR+VMDyyMqK4WT/RZTdWnQ NzI6U5nYfmzH1MUHIriUPl1o4ue6+nZRkj9/+v9rpFIAxiHR5ozgmNw7mJQxmFGLzBsD hRpwBkpIMdp0Q7tQjfQ4zwqySQxRIGHaDW/vbSl4Ci0sJG0Zuy4O6KzueEPGdV1PJsr2 aWpRzclcSf5reNW9tZrP8T/yR+X0+tablofYN9LV90yWccfQX7UHB/Eq+7rXaLTw5Bap TftMBxmA9rywu5Z8Uk1opZcQYseHmcUGcd7zTlaxRvzdjK92PHwKGM5MfN1y9B3Y9vc9 +Q0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=IXUtJ5Sz; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lz7si3227346ejb.725.2021.01.28.10.48.25; Thu, 28 Jan 2021 10:48:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=IXUtJ5Sz; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232250AbhA1Srm (ORCPT + 99 others); Thu, 28 Jan 2021 13:47:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232464AbhA1Sph (ORCPT ); Thu, 28 Jan 2021 13:45:37 -0500 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6EA2C06178A; Thu, 28 Jan 2021 10:44:56 -0800 (PST) Received: by mail-ed1-x529.google.com with SMTP id d2so7843018edz.3; Thu, 28 Jan 2021 10:44:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7KqrQELa5Ib7c8yGtm34ctZRTTgOgBVXw/XDTJkuZzM=; b=IXUtJ5Szhp/b70fyb4fSpJB8MQDglir6QCQtRcOrmv1bOwcD30SolN6AWHVYYLzuwS Ph9uWqoX8bPzCBV5yduoFUKIMf/UTx1rJTaO0PZoaUQLZXV3B5EJcQQxwUEA5XuZ2d3s CPYwOuFB3/APwHAQ3lBl+Ic/R+5RplfC+/sBICq2Xs93/BbeEaV7gefkYvgc7UaF9nKw pyXGaplyNyZNFjRpLi+t3zesfnHoGqLYcjCKlX9WVN5eFXEW32BbGusLapPR6aRLoKeC lzeArUreGdckovm7Dnp8qmYzXUyrLZzgSqhE+N8/+Nx25xagQ7UO5FFCOQIdZfC0vK1X vkOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7KqrQELa5Ib7c8yGtm34ctZRTTgOgBVXw/XDTJkuZzM=; b=ogCpXC1JFrPWlzMro0/tNi/7ppNGLQ12sWKglQh68DwsU4Hwua/wq12JoAVsozlJQ5 LKnXr4HE61jjgPmCegWsvDcat463jPkB2ZQ7yKPZqLnytQppMDfuFZwAlHNo1bKs/le1 fJ1ykVjQIZ+WbvWR6J6TAtrNL1X/gl+2N+sl3nB4Q1z4r7rPul7mmZOZ0iXeyhYGdJFR ReZ2GnzVYLvRnKP8hxtdzcYfPem4iSrAoZCFaVDR+qgrKcgXPYuHbKGU0aXyEubQnxHy C6MJiIKJ7EgZjx568MkP3c0qPhmvXMiHAxh+BHF99JiNf75bLOlyTbW/fQ59GVS+OCuf bRnA== X-Gm-Message-State: AOAM530xWh0hcK+GJSM+lwrOlwFYbX8sPLyn0POZRzGlf70LRQhqYY/l X9v7n/5hYb5AWLGVKJkqMVGXaixNpCOxOtek6kg= X-Received: by 2002:aa7:d1d7:: with SMTP id g23mr1120272edp.6.1611859495550; Thu, 28 Jan 2021 10:44:55 -0800 (PST) MIME-Version: 1.0 References: <20210128171048.644669-1-colin.king@canonical.com> In-Reply-To: <20210128171048.644669-1-colin.king@canonical.com> From: Willem de Bruijn Date: Thu, 28 Jan 2021 13:44:18 -0500 Message-ID: Subject: Re: [PATCH] rtlwifi: rtl8192se: remove redundant initialization of variable rtstatus To: Colin King Cc: Ping-Ke Shih , Kalle Valo , "David S . Miller" , Jakub Kicinski , linux-wireless , Network Development , kernel-janitors@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Thu, Jan 28, 2021 at 12:15 PM Colin King wrote: > > From: Colin Ian King > > The variable rtstatu is being initialized with a value that is never > read and it is being updated later with a new value. The initialization > is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King (for netdrv) Acked-by: Willem de Bruijn