Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3340147pxb; Sun, 31 Jan 2021 12:29:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJwOhc/DvexWijlIpTSzb0AiF+VQb0R5Ac86Gq4LlqlZHG9murPnh6fg5geBwpE74WixZmvd X-Received: by 2002:a17:906:1dc2:: with SMTP id v2mr14837348ejh.136.1612124985354; Sun, 31 Jan 2021 12:29:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612124985; cv=none; d=google.com; s=arc-20160816; b=u7BhmrD7dOl7wYsz1wB87l2fiVRBEfwwQhJVMzuk5rpJfAvkZgUX8CgxunGLO1aQW7 EA3ZMx6idrRF9r2cRyALX/HIubwD8QCXIDgbgMYqozEss9jTY9PEMM+hiDVjETBKBnTZ 7Sf/CoPAFNWFL8s7BljyISECV7jMHxZ/72R8YTYdApljuEwfF65eHC6KNrAJwaoG/bgt 8J0vuqwMxbkXhowddBlJy+3hyGWTKgqvHa6Hp6rlFZpg01YnZ3e+WkU5TKYUHH3jV5TO nxVqDTiuRDOhQdIBmZzYt2A1Qo5eckJaOm5XgHBSToAP6H8RDb3jM5oPGzNPIHJpQaRc AkwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:cc:to:from; bh=2UBPgqAjff45W0yYYOPd8NOpPFm5lVE6AfK9ziuqsSs=; b=eortJAr0agujZRODrI1+UaUOyFUmw8fL1v4ELDbFsGXYHysAm4rmT+orXqJG0qSYHf aggI7SaebBq9PFO5tYCI1WX+VokT17rQGt+/yW1CpN82HwIVsw5bEVwtX7Hzt+hK1bh3 MVzUdWHe0iXs9QNUmkm6sSatEWY2fWG35BVjW4VimPMFMcmCD2rMqz10hD3qMOvk83B2 sp4pIoWlJl50icBahAJZHd3kyDAhW2pvyeviqRGZ0MLaooN3NxRyRDIIh57h3SsgcBz5 7LHaPWQXnhnIfvbKHYMwVnTGLc1EoQzHLb7GNvtEjQpmVWAH0EdxHmxIYKRlCx+k33qC TaAg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h17si9764046edv.235.2021.01.31.12.29.18; Sun, 31 Jan 2021 12:29:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230210AbhAaUYp (ORCPT + 99 others); Sun, 31 Jan 2021 15:24:45 -0500 Received: from paleale.coelho.fi ([176.9.41.70]:43162 "EHLO farmhouse.coelho.fi" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S232021AbhAaULY (ORCPT ); Sun, 31 Jan 2021 15:11:24 -0500 Received: from 91-156-6-193.elisa-laajakaista.fi ([91.156.6.193] helo=redipa.ger.corp.intel.com) by farmhouse.coelho.fi with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1l6HMZ-0041H2-4u; Sun, 31 Jan 2021 20:22:19 +0200 From: Luca Coelho To: kvalo@codeaurora.org Cc: linux-wireless@vger.kernel.org Date: Sun, 31 Jan 2021 20:22:06 +0200 Message-Id: X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210131182212.929755-1-luca@coelho.fi> References: <20210131182212.929755-1-luca@coelho.fi> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on farmhouse.coelho.fi X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, TVD_RCVD_IP autolearn=ham autolearn_force=no version=3.4.4 Subject: [PATCH 06/12] iwlwifi: mvm: set enabled in the PPAG command properly Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Luca Coelho When version 2 of the PER_PLATFORM_ANT_GAIN_CMD was implemented, we started copying the values from the command that we have stored into a local instance. But we accidentally forgot to copy the enabled flag, so in practice PPAG is never really enabled. Fix this by copying the flag from our stored data a we should. Signed-off-by: Luca Coelho Fixes: f2134f66f40e ("iwlwifi: acpi: support ppag table command v2") Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/fw.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c index be1cc8653147..9f8751ceb45b 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c @@ -999,6 +999,8 @@ int iwl_mvm_ppag_send_cmd(struct iwl_mvm *mvm) return 0; } + ppag_table.v1.enabled = mvm->fwrt.ppag_table.v1.enabled; + cmd_ver = iwl_fw_lookup_cmd_ver(mvm->fw, PHY_OPS_GROUP, PER_PLATFORM_ANT_GAIN_CMD, IWL_FW_CMD_VER_UNKNOWN); -- 2.29.2