Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp4155976pxb; Mon, 1 Feb 2021 14:07:30 -0800 (PST) X-Google-Smtp-Source: ABdhPJxbSBg1X3ZXGjW6j2QHwfkY47fA2FafO/878ll4PmusjDEaFEUYIZQnlSeAuQlom5afPKvL X-Received: by 2002:a17:906:7c57:: with SMTP id g23mr19550860ejp.364.1612217250590; Mon, 01 Feb 2021 14:07:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612217250; cv=none; d=google.com; s=arc-20160816; b=W0WVpuFJHp19yI8nBqhy7q8dlVVE4Izq+7YmdkAU+GMmWN5Pax9/Il7FVz5a9BlCBE OdOKmGByY8XJSDdlBfjDUOA+xh6nVGYOg92BI4fsaXPpihXKS49Fak1a0/lXnXGc1MQY GYYV2t7s8682Y8XdQ+dHwPGPT/zq/mtcPep9NXE95OjEreSonPUDy+1xas4jLAEgoMJG PYTenXWMz+QvkzqlQvOApwAmisYY9sRTjkfzm62gs0T5HG0OdoRDZHG9iJ2a+ISw3Pbb i7c9DJN3TBuaBmOtzTN7vNkYez84hpPbyGSXp0j0t0x+WY6niwXxajUhNyKt/8kCGVPW QDkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=B49gml/8cpgz8Os7F0PVegLTz0oYjIQVNIevIep8kh4=; b=l6xZVO9wGZCbeEDlSTi4SFOE3G2SeZe1cCqCzi8EYYzGWrbjjtUaoVZWzVm1NDOLBi w6HOt8pa1lWZX/fHr5WNcxCGkZ4itAMS/e4By/GZ9dfdyV812DgMTab4J6bGgavMYsUk 2c6jOmj37wSEz4RQlkbYGZz8YmXvG6N9VgttsEcWNUVf087IrZ4tDsV6DT0G9klyrp9S WN0XFLBxX36nG1jUK1pAbQnkRyCDnVFPNulJ5cZOuCB1ko3Wm5SJwfuKmr7aEiz4jGC0 6/lBodFwtNmEQTrgmED0UCLupo2gl2hB8yjtFSAif3WGbGhWZIAYE40+yskxrTuHg1Ie ht+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Gh9nYVSm; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b24si11066861ejp.190.2021.02.01.14.07.04; Mon, 01 Feb 2021 14:07:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Gh9nYVSm; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230070AbhBAWEh (ORCPT + 99 others); Mon, 1 Feb 2021 17:04:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230039AbhBAWEW (ORCPT ); Mon, 1 Feb 2021 17:04:22 -0500 Received: from mail-oi1-x233.google.com (mail-oi1-x233.google.com [IPv6:2607:f8b0:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB9D0C061756 for ; Mon, 1 Feb 2021 14:03:42 -0800 (PST) Received: by mail-oi1-x233.google.com with SMTP id h192so20597887oib.1 for ; Mon, 01 Feb 2021 14:03:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=B49gml/8cpgz8Os7F0PVegLTz0oYjIQVNIevIep8kh4=; b=Gh9nYVSmTAOkcwnoYC7iPOHwxtJA70Mk0Z650ygrrx6ADWq9ub7IYWOPuASCC9cfkR GNhMZJWnjvwu8PZuhQEAvjEz9dOe5j3dbaPZKcR1CsU4U6CZJNDNcG3q1TzPmIR7xT5+ 57Fg8AK0YFDpp5Gd6AIZUFWO5td0ItCu3ZNxs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=B49gml/8cpgz8Os7F0PVegLTz0oYjIQVNIevIep8kh4=; b=aXwJplMiN6b1r3bRxY6Zls9xoAQ2hyuMsA79mZ2YYSjVE7GNw9yM2FKUa0FynvzBBk bC1SLYiI3vwt5tUsSurYm9t49NhbV7aMz5e4qXdWGwkor544ZkkjHNZWcnOrfi6nnliT 8WP7+U/UnPvDif33MFoGbMpcnO2oW9QA+8YW4jC6f+WZfDiq10tqd2511pvkAH40yjDW jPRfWRTHXmNIVjoL/AJ+QneWRWgYS6BD5xtwac24XgH//56iZtGCppYtdsBavnnEPZXC hS2fXguA/2gWAI1N0iFoHljj2IhLSGIRdGffkSjfqFXLEwvtAUCLXqc2R41/lJ6hYwWK j6/Q== X-Gm-Message-State: AOAM532kEIFrRLF+D/JimLxSkKFLnopEGINqzjC0OflLGvtuMu6NmEWs 59ZbMy5xwCkYGlUbcUKnPIHuCzkkbLfACQ== X-Received: by 2002:aca:5954:: with SMTP id n81mr659650oib.25.1612217022024; Mon, 01 Feb 2021 14:03:42 -0800 (PST) Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com. [209.85.167.182]) by smtp.gmail.com with ESMTPSA id h18sm4268471otk.26.2021.02.01.14.03.39 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Feb 2021 14:03:40 -0800 (PST) Received: by mail-oi1-f182.google.com with SMTP id j25so20622060oii.0 for ; Mon, 01 Feb 2021 14:03:39 -0800 (PST) X-Received: by 2002:aca:f40c:: with SMTP id s12mr622260oih.105.1612217018531; Mon, 01 Feb 2021 14:03:38 -0800 (PST) MIME-Version: 1.0 References: <20210201070649.1667209-1-yenlinlai@chromium.org> In-Reply-To: <20210201070649.1667209-1-yenlinlai@chromium.org> From: Brian Norris Date: Mon, 1 Feb 2021 14:03:26 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] mwifiex: Report connected BSS with cfg80211_connect_bss() To: Yen-lin Lai Cc: linux-wireless , Amitkumar Karwar , "David S. Miller" , Ganapathi Bhat , Jakub Kicinski , Kalle Valo , Xinming Hu , Linux Kernel , "" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Sun, Jan 31, 2021 at 11:07 PM Yen-lin Lai wrote: > When a network is moved or reconfigured on the different channel, there > can be multiple BSSes with the same BSSID and SSID in scan result > before the old one expires. Then, it can cause cfg80211_connect_result > to map current_bss to a bss with the wrong channel. > > Let mwifiex_cfg80211_assoc return the selected BSS and then the caller > can report it cfg80211_connect_bss. > > Signed-off-by: Yen-lin Lai This seems sane to me: Reviewed-by: Brian Norris