Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] ath11k: Update tx descriptor search index properly
To:     Karthikeyan periyasamy <periyasa@codeaurora.org>
Cc:     ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
References: <1608305041-21946-1-git-send-email-periyasa@codeaurora.org>
 <959ea12a-e35b-5867-c55e-7f62e2956b09@eero.com>
 <d6cbfd2aff787faa3be69252b2677df9@codeaurora.org>
 <08ef5e10-de7a-fe13-d23a-d1afa1dbd0e5@eero.com>
 <ea757176a6438f1b0cf9bee41f8a9f8c@codeaurora.org>
 <dc8f531f-2ab5-f690-2b94-917880682fcc@eero.com>
 <7e3bae2db30d90963f96bb9be82951f0@codeaurora.org>
From:   Peter Oh <peter.oh@eero.com>
Message-ID: <ea3fb227-8324-dd73-f400-b6e591bc91df@eero.com>
Date:   Wed, 3 Feb 2021 19:37:35 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <7e3bae2db30d90963f96bb9be82951f0@codeaurora.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk


On 2/3/21 7:17 PM, Karthikeyan periyasamy wrote:
> On 2021-02-04 08:38, Peter Oh wrote:
>> On 2/3/21 5:08 PM, Karthikeyan periyasamy wrote:
>>> On 2021-02-04 00:59, Peter Oh wrote:
>>>> On 1/26/21 6:46 PM, Karthikeyan periyasamy wrote:
>>>>> On 2020-12-19 00:53, Peter Oh wrote:
>>>>>> On 12/18/20 7:24 AM, Karthikeyan Periyasamy wrote:
>>>>>>> Tx descriptor search index field should be updated with hw peer id
>>>>>>> and not by AST Hash. Incorrect search index causes throughput 
>>>>>>> degradation
>>>>>>> in all the platforms. so updated the search index field with hw 
>>>>>>> peer id,
>>>>>>> which is a common change applicable for all the platforms.
>>>>>>>
>>>>>>> Tested-on: IPQ8074 hw2.0 AHB 
>>>>>>> WLAN.HK.2.4.0.1-01492-QCAHKSWPL_SILICONZ-1
>>>>>>>
>>>>>>> diff --git a/drivers/net/wireless/ath/ath11k/peer.c 
>>>>>>> b/drivers/net/wireless/ath/ath11k/peer.c
>>>>>>> index b69e7eb..f49abefa 100644
>>>>>>> --- a/drivers/net/wireless/ath/ath11k/peer.c
>>>>>>> +++ b/drivers/net/wireless/ath/ath11k/peer.c
>>>>>>>
>>>>>>> @@ -309,7 +310,11 @@ int ath11k_peer_create(struct ath11k *ar, 
>>>>>>> struct ath11k_vif *arvif,
>>>>>>>         peer->pdev_idx = ar->pdev_idx;
>>>>>>>       peer->sta = sta;
>>>>>>> -    arvif->ast_hash = peer->ast_hash;
>>>>>>> +
>>>>>>> +    if (arvif->vif->type == NL80211_IFTYPE_STATION) {
>>>>>>> +        arvif->ast_hash = peer->ast_hash;
>>>>>>> +        arvif->ast_idx = peer->hw_peer_id;
>>>>>>> +    }
>>>>>>
>>>>>> How about non STATION type?
>>>>>>
>>>>>
>>>>> no need of configuring the ast_idx, ast_hash field for non station 
>>>>> type. Its recommended by HW/FW team.
>>>>>
>>>> Can you add this comment in commit message?
>>>>
>>>
>>> sure
>>>
>>>> Also could you include the answer to "what conditions you observed the
>>>> throughput degradation?" in commit message too?
>>>
>>> In all the scenario will see degradation. Its a general improvement.
>>>
>> It sounds good and it will better if you share the number before and
>> after the patch.
>
> I have seen 10% increase in WDS scenario.
>
> Thanks,
> Karthikeyan P

Thank you for the sharing.

BTW, all such information should go to commit message.

Peter