Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1818550pxb; Fri, 5 Feb 2021 02:08:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJzMvxDHS4JEaDz8bR0MwhOPb/PC+kYf6unTb5RRlVdlYbPS232b3YeyYGb/7madx74qH3oW X-Received: by 2002:a05:6402:34c3:: with SMTP id w3mr2885040edc.3.1612519691637; Fri, 05 Feb 2021 02:08:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612519691; cv=none; d=google.com; s=arc-20160816; b=OGGQwCDWhqr0ys6/Scto5Q38jdV+7Tojx1hsVGRLdXbW65Dtp4YE+N50RHLBVJBDvi +GTeCxL2ybYE0n0RfMG+4U5Zt7U+tpEjsFAQ36+6xv2DoAEFWyIaUZTZb31aW5sheKVI llvSI2I0CB3qCX8NVZtMeNOFLhWsGh0BT7SRGoinL0y7tkeKDWSWu86zJrMic4/TbBcX reZ8OKU7R70zfXHUQStt2bvQPJ2JhQWF19djiQ+POO+h7eC+W8ww678dWvs9Pg8/4qqc 6YF/67O9j6WvjCub/aZJ0/6/5OSoJvcG4tVsxAFxdg5LZ9SAKroWFgTaP6qnZVizAusw quTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:date:message-id:user-agent:cc:to :references:in-reply-to:from:content-transfer-encoding:mime-version; bh=UE9oxZyAszMWByIW1am2meN3yOkqEtARWMi0jtab8B4=; b=Kv5aoZqHu4hQR4lnKB/Y8IZDiHQGXvc1yS9MyVGFqztFmTl7BYjUESa48SQQj9DWge uYxJoobihd+8OL48sMz2VuCQLspheRsEbHbcOi0mqUeXJ182zfhcrLEX0jvFktYO6/9e p0YX5scLNFYeAc7Sxv+Sg7z1iPlABMDTtWlDSVs+Om2z7nYd8HaczjMcv/wNwwiiEmMb 7VnQ+UtcQ2NsIc3f18GPb8ut8UL5WjoPLOealxLPKIlgEjR9UxU2h2xEoV3zzA5Q/vSZ UV8ONbyoCZt3cHFuhgkEJCPKC2qU3M8AZ10PEmfHpXhXuv6hnliA4EOGXG4ag/152gTI scaA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e9si5112892eds.558.2021.02.05.02.07.47; Fri, 05 Feb 2021 02:08:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230126AbhBEKF2 (ORCPT + 99 others); Fri, 5 Feb 2021 05:05:28 -0500 Received: from paleale.coelho.fi ([176.9.41.70]:43860 "EHLO farmhouse.coelho.fi" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S230378AbhBEKB2 (ORCPT ); Fri, 5 Feb 2021 05:01:28 -0500 Received: from 91-156-6-193.elisa-laajakaista.fi ([91.156.6.193] helo=[127.0.1.1]) by farmhouse.coelho.fi with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1l7xuT-0044mc-N3; Fri, 05 Feb 2021 12:00:18 +0200 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Luca Coelho In-Reply-To: References: To: Luca Coelho Cc: kvalo@codeaurora.org, linux-wireless@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.9.1+ Message-Id: Date: Fri, 05 Feb 2021 12:00:17 +0200 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on farmhouse.coelho.fi X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, TVD_RCVD_IP autolearn=ham autolearn_force=no version=3.4.4 Subject: Re: [RESEND PATCH 10/12] iwlwifi: pcie: Disable softirqs during Rx queue init Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Luca Coelho wrote: > From: Ilan Peer > > When Rx queues are configured during module init, NAPI is enabled > while the Rx queue lock is held. However, since softirqs are not > disabled, it is possible that and IRQ would fire and call > iwl_pcie_rx_handle() which would also try to acquire the Rx lock. > > Prevent this by disabling softirqs during Rx queue configuration, > as part of module init flow. > > Signed-off-by: Ilan Peer > Signed-off-by: Luca Coelho Patch applied to iwlwifi-next.git, thanks. 47ef328c2090 iwlwifi: pcie: Disable softirqs during Rx queue init