Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3889760pxb; Mon, 8 Feb 2021 02:44:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJwtD2xcfabovHxKLJ9XOUK2/6IhTmry4Lo77hVTBUUvGEzPMMLf7vDnDACkpyFZy1jL2Hiq X-Received: by 2002:a17:906:660b:: with SMTP id b11mr17171019ejp.458.1612781082074; Mon, 08 Feb 2021 02:44:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612781082; cv=none; d=google.com; s=arc-20160816; b=uOmJpeCBo9KPYTFpA6H7Yu6rmptdAVqsmASRaXWwADBtRZwH+bcVasJYWobWYzOoC5 skTN9shWAdTWumt0sR8gEY5bfa1Zxrem42pevmuvPP5Q8HLExGJK5iMinhjnuICnu/Ja WMMqxCkl3WU6FOhyv0OFwFVadmQDxUL2THREuqXMnQYIA7Xr/EZmulhTjz7+275DuBbv 3iwYmA4IKgxREN7l+uLH2LCUrzCdtvNF2kSGbAvuu29fXg2f5he1haeS42J4sGQmgKhz DdZYMJyNaIXTIZc9np4e6GdzBc1UGQ8VJNfXVc4JiK4lmJGLPCufohKjIhN2QPXV8day oydg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dmarc-filter:sender:dkim-signature; bh=rsWO5gVXQJgQ7C6h+zCZSstEnkqvJD9Aka1MxQopoAM=; b=EZmMDu4KF5wmKnum+jNQwsFUpywogqlFLBxLEKstsIYbVjVxYmDcSf9l4cloIGPPdu jqKZQhsezN3/rt5J3d8K6K/A/4dPOQaGdW8c6kHF2T03YmbkcEUG9+6ttIpocAV/V4ZE 2sf5xgzKJwrzkaMoRUzWeSaASzrM5Zq4RuLMEWPFrCWrfBbBs0lyRvsAEl5KfNQPpSyk MdQRz4RDPc4OOMBxfrqMmxs0ScyNN+wRlfiqrMCYBHzC7jZXuBmBJ7n/fs8KoiIOCMo9 uG0UBacO/Zu0P1Byb49DGIRHacQJD+pUw59HVQ4/A1ifxEzH9i/RGZL5mPe/70P5QUG4 ftLg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=gQqmeRji; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g24si10623960edu.329.2021.02.08.02.44.18; Mon, 08 Feb 2021 02:44:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=gQqmeRji; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232645AbhBHKma (ORCPT + 99 others); Mon, 8 Feb 2021 05:42:30 -0500 Received: from mail29.static.mailgun.info ([104.130.122.29]:47554 "EHLO mail29.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232381AbhBHKkY (ORCPT ); Mon, 8 Feb 2021 05:40:24 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1612780800; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=rsWO5gVXQJgQ7C6h+zCZSstEnkqvJD9Aka1MxQopoAM=; b=gQqmeRjixO4aOa5voWWPUS4uQ3WYSwHi7ALPUXj5J7kW4gYsbGSsOypJvKvU8s5d3X4L4gks aNC7bN+1B+EyPYAX8n/I5qEwl/CLKUsD4EkNgj93U9JRKOgGVBdE/hc+iAKq34+v8fzH/SU1 aqbGjBIM9xi6Vs58EYVf5AQm3mE= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-west-2.postgun.com with SMTP id 602114e58e43a988b7a023a6 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 08 Feb 2021 10:39:33 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id CF51AC43464; Mon, 8 Feb 2021 10:39:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,BAYES_00, MISSING_DATE,MISSING_MID,SPF_FAIL,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 7F72AC433ED; Mon, 8 Feb 2021 10:39:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 7F72AC433ED Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] rtlwifi: rtl8192se: remove redundant initialization of variable rtstatus From: Kalle Valo In-Reply-To: <20210128171048.644669-1-colin.king@canonical.com> References: <20210128171048.644669-1-colin.king@canonical.com> To: Colin King Cc: Ping-Ke Shih , "David S . Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20210208103932.CF51AC43464@smtp.codeaurora.org> Date: Mon, 8 Feb 2021 10:39:32 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Colin King wrote: > From: Colin Ian King > > The variable rtstatu is being initialized with a value that is never > read and it is being updated later with a new value. The initialization > is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King > Acked-by: Willem de Bruijn Patch applied to wireless-drivers-next.git, thanks. 711fa16f1dfe rtlwifi: rtl8192se: remove redundant initialization of variable rtstatus -- https://patchwork.kernel.org/project/linux-wireless/patch/20210128171048.644669-1-colin.king@canonical.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches