Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3911598pxb; Mon, 8 Feb 2021 03:22:13 -0800 (PST) X-Google-Smtp-Source: ABdhPJzJDmiyJB0vLZyl5ejBwYWShCmV35zbpN9I2UwhJt94FcU1GAoG26vMdKAflMiuI/k1heXY X-Received: by 2002:a17:906:c455:: with SMTP id ck21mr16914164ejb.354.1612783333052; Mon, 08 Feb 2021 03:22:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612783333; cv=none; d=google.com; s=arc-20160816; b=cDFDpVExJoaiCvUQzg0a9PoN2kFqEqn8Pj5CjnfQkhQb47qBzeIyBuTPKwu/4wsW2j HtZLIIqlzPfV9XuNHV2iDicHRLYyB/Pk2WdQQNKNny2IsL1Bwe5cQ20yJ29Hj2FfxtE3 pK/y0LT9DwzGrQMWj4AhFVhIzPy627vuhc//6L0Lc6RfVr6pWrpFD35fWDNliQyasLYF Kw0xpIPk0WAZzVOiXQ2uO519dZ6KIOiGdyKc6duD//+Xg8iXNHVP5vF72Q6UastFEyUZ O6e5tbpmpfw88WAgUXJwCd60WzP3iNh9O5Zllt6aGiHO0bv+SpVmI0r7PLZC6khfphlQ bL5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dmarc-filter:sender:dkim-signature; bh=4yovXiO97+KUB9NrGHFaAqtVpDFTNnk943mQ48WhbCc=; b=CCT2IdI+nrk79nzZvVl7mJnDhZJHxsUcJJl9envzyzy8c4ehB1HSRTJbyWE+mr83BT Y26I0udKmXB03JNa5s5IazPezhSBv7g1GSB267+5RJc+kUtjmLAQ2BcrJDHDAt36QytS /fj8KM01ro+6O7Xye00ddtwqlgu7VMzN14PzOuZ+ZkgmHRADh0mpVNJXm7Zlg/IepM90 hg+GZigeeqh01oP5ulaiaoGLpkMSBeQpVmxpFR7D0LDv9Knd8soFpc3fYNgtuD8xWRvy wPSyYeSlY8zXo48iRxFLA+QIuZkPPxmAMI84YolgmySo5wY5b43/kUnv3I4y1sgM1Kor veoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b="D0dI/awJ"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j17si5564735edw.10.2021.02.08.03.21.49; Mon, 08 Feb 2021 03:22:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b="D0dI/awJ"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232897AbhBHLTe (ORCPT + 99 others); Mon, 8 Feb 2021 06:19:34 -0500 Received: from mail29.static.mailgun.info ([104.130.122.29]:60220 "EHLO mail29.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233068AbhBHLQ4 (ORCPT ); Mon, 8 Feb 2021 06:16:56 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1612782999; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=4yovXiO97+KUB9NrGHFaAqtVpDFTNnk943mQ48WhbCc=; b=D0dI/awJhJT1PoX/ub2C2zFDF9Rmj1NpU1xNo7bOYmshyajRUMYmq/ti9Cf4yXGgVaWjVdd8 OrpnwRsXH+kuPye+nNrJqa07ux8ylXMp49Mltnn0PE/2hMesLjfJY9e91Hy7tXNHi4yvxwE6 dfQHUXsZvUgDxZYoCqQnhtqOh10= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-west-2.postgun.com with SMTP id 60211d728e43a988b7b51a87 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 08 Feb 2021 11:16:02 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id D6703C433ED; Mon, 8 Feb 2021 11:16:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,BAYES_00, MISSING_DATE,MISSING_MID,SPF_FAIL,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 955E7C43462; Mon, 8 Feb 2021 11:16:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 955E7C43462 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] libertas: remove redundant initialization of variable ret From: Kalle Valo In-Reply-To: <20210128162202.642848-1-colin.king@canonical.com> References: <20210128162202.642848-1-colin.king@canonical.com> To: Colin King Cc: "David S . Miller" , Jakub Kicinski , libertas-dev@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20210208111602.D6703C433ED@smtp.codeaurora.org> Date: Mon, 8 Feb 2021 11:16:02 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Colin King wrote: > From: Colin Ian King > > The variable ret is being initialized with a value that is never read > and it is being updated later with a new value. The initialization is > redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. 1d5248882d64 libertas: remove redundant initialization of variable ret -- https://patchwork.kernel.org/project/linux-wireless/patch/20210128162202.642848-1-colin.king@canonical.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches