Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1270033pxb; Wed, 10 Feb 2021 04:36:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJxFCCZS3O3+vBqyUawXP5/2a97guMv0t4+N4Om0MUT4/WAyu917j2FfCJ3hSqTBNxrCqNk/ X-Received: by 2002:a17:906:378d:: with SMTP id n13mr2667523ejc.386.1612960584851; Wed, 10 Feb 2021 04:36:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612960584; cv=none; d=google.com; s=arc-20160816; b=oJUalxRZUGQjkADltPlup4Lt9PlBV1SLexmyN00ySl2X8KC3gKwzYq4RnOGXZPl04+ F+tuHYqv4V5QeWaPizV2cRdePLTAxtG/mytyQMBwsZqOssFPFaodA8aMxbjOA/cY7c9Q Co0k5fxwLIIyHmhDIRGxDXzNUTY0UXpRFyyunWsnlAgkwTHOrsjPFXmfWqT/Re0kTF81 sdRHT4wkEdJAdI4qdcf2uhgwqCuSSrs3aqgaSWE7cebOv85ag6ZStfxqSQ87S9qYmfJY q4zTDkuc32+PnOD/IGiPz3ddLx7Gw4WTe5wMlwoj7NdkOw56+188d06sRAP8hbCOg1vA V/Yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:cc:to:from; bh=4NlKJQxkcAK8z0skmo0rrWllwiKSzBM1WD9Ci7POkKc=; b=gl4e0Pv/QLJRgBVh9pV/BA2KbNh3LmNavyPM0HA05qWEj8gLcBKeIyDbQfQDx0Doo+ 8QeHBW8L+S0kGq72naaZpTS5iKeegRR/zM13CvQj49jx+U63qxcE96M41dWpZb+UtLl1 /uFH2d+YveckykIbbrBRGvUMFu4352S0g2tYPlI/AyiRHz6aoIkhMA2Y4LR38endBKxt 2NJ0Vc2lK2fz0JZ2P1X84YARulL7rZ/LpQc51XwXKnmn6ES3RXbqHQH1o2x+6T1Bqg4I IjVwqjf/4byX+viK1rb4ZTftqpfozPQUAxSKkcIG1I5sqjFRbi/G6rh9cFXbY4BAyxTc +u6Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f20si1200716ejk.711.2021.02.10.04.36.01; Wed, 10 Feb 2021 04:36:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232021AbhBJMfq (ORCPT + 99 others); Wed, 10 Feb 2021 07:35:46 -0500 Received: from paleale.coelho.fi ([176.9.41.70]:45138 "EHLO farmhouse.coelho.fi" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S231830AbhBJMdm (ORCPT ); Wed, 10 Feb 2021 07:33:42 -0500 Received: from 91-156-6-193.elisa-laajakaista.fi ([91.156.6.193] helo=redipa.ger.corp.intel.com) by farmhouse.coelho.fi with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1l9oci-0049Yg-Fs; Wed, 10 Feb 2021 14:29:36 +0200 From: Luca Coelho To: kvalo@codeaurora.org Cc: linux-wireless@vger.kernel.org Date: Wed, 10 Feb 2021 14:29:26 +0200 Message-Id: X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210210122927.315774-1-luca@coelho.fi> References: <20210210122927.315774-1-luca@coelho.fi> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on farmhouse.coelho.fi X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, TVD_RCVD_IP autolearn=ham autolearn_force=no version=3.4.4 Subject: [PATCH v2 11/12] iwlwifi: pcie: don't crash when rx queues aren't allocated in interrupt Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Emmanuel Grumbach WARNING is better than crashing. Since this happened to me, be on the safe side. Signed-off-by: Emmanuel Grumbach Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/pcie/rx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/rx.c b/drivers/net/wireless/intel/iwlwifi/pcie/rx.c index 534fe62b8a30..42426e25cac6 100644 --- a/drivers/net/wireless/intel/iwlwifi/pcie/rx.c +++ b/drivers/net/wireless/intel/iwlwifi/pcie/rx.c @@ -1658,6 +1658,9 @@ irqreturn_t iwl_pcie_irq_rx_msix_handler(int irq, void *dev_id) if (WARN_ON(entry->entry >= trans->num_rx_queues)) return IRQ_NONE; + if (WARN_ONCE(!rxq, "Got MSI-X interrupt before we have Rx queues")) + return IRQ_NONE; + lock_map_acquire(&trans->sync_cmd_lockdep_map); local_bh_disable(); -- 2.30.0