Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1270683pxb; Wed, 10 Feb 2021 04:37:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJxNpFoxld8S0pvbxSmfBHlr1uyR6DnERRQ+QiZyJwSAM4Ie6GjILTUcFVQJU2COgM4Ol+bO X-Received: by 2002:a17:906:35d9:: with SMTP id p25mr2734716ejb.398.1612960653431; Wed, 10 Feb 2021 04:37:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612960653; cv=none; d=google.com; s=arc-20160816; b=EnoX2tfn5ajqLFlDcHcjQXor1SlWpWZFL62RYiHDg1JYBNSckTwDB+9cS6DnnYdAxm JQADzBtURwfpDMw+GA+8nuyf+FWVcCBeDinuajyG4TR6l0q2IxBAXtLDLAqGDXMIGvgp C6UgoTNydvfVFw4NjwDkElIpZkHv3kB5rO/gEr3YVdwQSRjCNtgfHsTo7LtrOdpYcDHZ Mh5MUTO5+mBE2PQVDwciUgxvt1toHbMjORNYrowa2iZsUuT73SD2wB5WhYTyo4+NdELN Yzaomeg6M79aeGBY04/5nerzFD7W23jT1yTAJbaczspYV6dEFh3FUDVu9QY9sdUISLtP /UOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:cc:to:from; bh=3hZk/wQTnS9sfWuiw0XKTjhJWwlRTy3hSpQkTsBKDEQ=; b=tOpAXRZdP/VjIj35DwwVvTTnqlKgwE+8ll88zuWPvzb91DxTjOWho/6WDinV+zBQyS fH69Ig23jbsQNZvodaEZI73Met18yhwQyMDRZrsQHBpNd0CdiOS4dm8aibaJO7Ar7hEy WpnYD+luBe+eSZNU+rYV3U8TKZTXudUK2HPX3qY0/ps2M+tM7JIlmZ4Qz6tKDIeaAx6G zwQz5CjdKdEipB6ZE0ivvPjwcZPprpUYhkciLlgauImSdKx12xOp31MHYPhXIXFFnT65 XysGRYR3zso7HR0kNVa2I/Xp9SxtnmBi8zn1yKT4YQ3mTmFdhJ+1Dy1eU4aJsPNKOmFS vdiw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f8si1289244edq.140.2021.02.10.04.37.10; Wed, 10 Feb 2021 04:37:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231778AbhBJMe3 (ORCPT + 99 others); Wed, 10 Feb 2021 07:34:29 -0500 Received: from paleale.coelho.fi ([176.9.41.70]:45122 "EHLO farmhouse.coelho.fi" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S231790AbhBJMcE (ORCPT ); Wed, 10 Feb 2021 07:32:04 -0500 Received: from 91-156-6-193.elisa-laajakaista.fi ([91.156.6.193] helo=redipa.ger.corp.intel.com) by farmhouse.coelho.fi with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1l9och-0049Yg-UO; Wed, 10 Feb 2021 14:29:36 +0200 From: Luca Coelho To: kvalo@codeaurora.org Cc: linux-wireless@vger.kernel.org Date: Wed, 10 Feb 2021 14:29:25 +0200 Message-Id: X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210210122927.315774-1-luca@coelho.fi> References: <20210210122927.315774-1-luca@coelho.fi> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on farmhouse.coelho.fi X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, TVD_RCVD_IP autolearn=ham autolearn_force=no version=3.4.4 Subject: [PATCH v2 10/12] iwlwifi: correction of group-id once sending REPLY_ERROR Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Mukesh Sisodiya Once sending the REPLY_ERROR group ID is not set and this lead to get it set to wrong value LONG_GROUP later in default handling Fix this by checking the REPLY_ERROR and avoid changing the Group ID Signed-off-by: Mukesh Sisodiya Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/iwl-trans.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-trans.c b/drivers/net/wireless/intel/iwlwifi/iwl-trans.c index f0985453c80b..60e0db4a5e20 100644 --- a/drivers/net/wireless/intel/iwlwifi/iwl-trans.c +++ b/drivers/net/wireless/intel/iwlwifi/iwl-trans.c @@ -13,6 +13,7 @@ #include "iwl-fh.h" #include "queue/tx.h" #include +#include "fw/api/commands.h" struct iwl_trans *iwl_trans_alloc(unsigned int priv_size, struct device *dev, @@ -161,8 +162,10 @@ int iwl_trans_send_cmd(struct iwl_trans *trans, struct iwl_host_cmd *cmd) if (!(cmd->flags & CMD_ASYNC)) lock_map_acquire_read(&trans->sync_cmd_lockdep_map); - if (trans->wide_cmd_header && !iwl_cmd_groupid(cmd->id)) - cmd->id = DEF_ID(cmd->id); + if (trans->wide_cmd_header && !iwl_cmd_groupid(cmd->id)) { + if (cmd->id != REPLY_ERROR) + cmd->id = DEF_ID(cmd->id); + } ret = iwl_trans_txq_send_hcmd(trans, cmd); -- 2.30.0