Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 3B34BC433CA
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH v2] wilc1000: Fix use of void pointer as a wrong struct
 type
From:   Kalle Valo <kvalo@codeaurora.org>
In-Reply-To: <YCQomJ1mO5BLxYOT@Vsevolods-Mini.lan>
References: <YCQomJ1mO5BLxYOT@Vsevolods-Mini.lan>
To:     Vsevolod Kozlov <zaba@mm.st>
Cc:     ajay.kathat@microchip.com, claudiu.beznea@microchip.com,
        linux-wireless@vger.kernel.org
User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2
Message-Id: <20210211064608.A03B5C433C6@smtp.codeaurora.org>
Date:   Thu, 11 Feb 2021 06:46:08 +0000 (UTC)
Precedence: bulk

Vsevolod Kozlov <zaba@mm.st> wrote:

> ac_classify() expects a struct sk_buff* as its second argument, which is
> a member of struct tx_complete_data. priv happens to be a pointer to
> struct tx_complete_data, so passing it directly to ac_classify() leads
> to wrong behaviour and occasional panics.
> 
> Since there is only one caller of wilc_wlan_txq_add_net_pkt and it
> already knows the type behind this pointer, and the structure is already
> in the header file, change the function signature to use the real type
> instead of void* in order to prevent confusion.
> 
> Signed-off-by: Vsevolod Kozlov <zaba@mm.st>

Patch applied to wireless-drivers-next.git, thanks.

6fe91b69cece wilc1000: Fix use of void pointer as a wrong struct type

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/YCQomJ1mO5BLxYOT@Vsevolods-Mini.lan/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches