Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 10B50C433CA
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Luca Coelho <luca@coelho.fi>
Cc:     linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] iwlwifi: pnvm: implement reading PNVM from UEFI
References: <iwlwifi.20210211015026.289084803334.Ie234805047df3be84f4235f9dafaf4cdecf0db9a@changeid>
Date:   Thu, 11 Feb 2021 18:21:47 +0200
In-Reply-To: <iwlwifi.20210211015026.289084803334.Ie234805047df3be84f4235f9dafaf4cdecf0db9a@changeid>
        (Luca Coelho's message of "Thu, 11 Feb 2021 01:50:41 +0200")
Message-ID: <87sg62shgk.fsf@codeaurora.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Luca Coelho <luca@coelho.fi> writes:

> From: Luca Coelho <luciano.coelho@intel.com>
>
> We now support fetching the PNVM data from a UEFI variable.  Add the
> code to read this variable first and use it.  If it's not available,
> we fall back to reading the data from the filesystem, as before.
>
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>

[...]

> --- a/drivers/net/wireless/intel/iwlwifi/fw/pnvm.c
> +++ b/drivers/net/wireless/intel/iwlwifi/fw/pnvm.c
> @@ -10,6 +10,7 @@
>  #include "fw/api/commands.h"
>  #include "fw/api/nvm-reg.h"
>  #include "fw/api/alive.h"
> +#include <linux/efi.h>
>  
>  struct iwl_pnvm_section {
>  	__le32 offset;
> @@ -219,6 +220,88 @@ static int iwl_pnvm_parse(struct iwl_trans *trans, const u8 *data,
>  	return -ENOENT;
>  }
>  
> +/*
> + * This is known to be broken on v4.19 and to work on v5.4.  Until we
> + * figure out why this is the case and how to make it work, simply
> + * disable the feature in old kernels.
> + */
> +#if defined(CONFIG_EFI)

The comment doesn't really make sense anymore, can you send a followupb
patch to remove it? No need to change the tag because of this.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches