Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2367454pxb; Thu, 11 Feb 2021 10:30:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJyWbK4m6jBorkBRz/c8jc2bCjrUospDE32x3qSeU9/hqJSlvX+lZnd6C8sAX4OIL/5BE1US X-Received: by 2002:a05:6402:1770:: with SMTP id da16mr9298082edb.203.1613068224860; Thu, 11 Feb 2021 10:30:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613068224; cv=none; d=google.com; s=arc-20160816; b=FLIHHvNCSDNkYD3JvVqBC4HjxrLAbVRYbSp9LJmdLrX29UdrWxgDii4jX/VH7Q1W/p 4yz16kHSKvyU8389XJ+Qu9xcmy4QvcH3yvC6g2Y4UnWBfM4OC+awXbKiK5ntm5WZRJdQ OvdJBT/RJJ5WkuBEEOXNRYxjH5dYmymS0SY5r1E+w52G5z01CXSr7cBg5bLkQMQQIAEA n6aTgi4NBQ/bObDfDGVJkf1IJm1GaEH1uwHhVndjaseisPZiqzTki3yKYvkInXpoxRXo rjOEgtoD/WeL4jjMY8hXeoeiAE8t5cBnvu5fGl/tI5DiV57Qcs7jaBUrSp/DkZgRh2/w Jz3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dmarc-filter:sender:dkim-signature; bh=XQMYp79ftc2CD2w0g/sVHwqX5MSlVZ7BvVff5QTyZow=; b=FzqyYkvwwTTTjk+zwnIzzkotztydy4Wsw5VUfJE1/qa4PJBo6uGyepXh4RpCsgDehT PeopDws8O3iDhD5K5HWM4uwnydc0YtUJknzpCOMJ8Fep2dsrEVnPQ5+joO8T4jmbK458 ptMAX3ztfE6c1rvgbSlIEqc7fjC2zIRlauG+MNnlEuFF7sVG+elZqVTTm7J9GPIKU/FH yFzewSVo2uK8IR1gZ91n9yMO7JCoVPtwvwE85lZjwciwaaDjBbOR3zJNclshaXIulU31 W2CTQZRFpmAwZc2sT3cG0zzTRMysq5zqmTGi9L8Fg7mCovAy3M6LDvC6+kzuH3Ea/z6j Aesw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=Hb4G4TJZ; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e13si4111483edz.214.2021.02.11.10.29.28; Thu, 11 Feb 2021 10:30:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=Hb4G4TJZ; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231927AbhBKS3J (ORCPT + 99 others); Thu, 11 Feb 2021 13:29:09 -0500 Received: from so15.mailgun.net ([198.61.254.15]:32638 "EHLO so15.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231922AbhBKS1i (ORCPT ); Thu, 11 Feb 2021 13:27:38 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1613068037; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=XQMYp79ftc2CD2w0g/sVHwqX5MSlVZ7BvVff5QTyZow=; b=Hb4G4TJZ+SjYLbrQlwCj3F0a7O/Xb/clNVa7xHeKC+5sr/jDs+HisW+REoWs3iZZg+EdNVNo NQf9kCGCOD8PlOd0tGids/i+MkJ67jol0MpOypzjukJrSMTd8rxofoCVRFePaeHucqjqCLSU 3mkq7UwVyqzJhQXSUNxjPhZDQAs= X-Mailgun-Sending-Ip: 198.61.254.15 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n07.prod.us-west-2.postgun.com with SMTP id 602576eb830f898bac351cf6 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 11 Feb 2021 18:26:51 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id B6B85C433ED; Thu, 11 Feb 2021 18:26:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,BAYES_00, MISSING_DATE,MISSING_MID,SPF_FAIL,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 08C17C433C6; Thu, 11 Feb 2021 18:26:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 08C17C433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2] ath10k: hold RCU lock when calling ieee80211_find_sta_by_ifaddr() From: Kalle Valo In-Reply-To: <20210210212107.40373-1-skhan@linuxfoundation.org> References: <20210210212107.40373-1-skhan@linuxfoundation.org> To: Shuah Khan Cc: davem@davemloft.net, kuba@kernel.org, Shuah Khan , ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20210211182650.B6B85C433ED@smtp.codeaurora.org> Date: Thu, 11 Feb 2021 18:26:50 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Shuah Khan wrote: > ieee80211_find_sta_by_ifaddr() must be called under the RCU lock and > the resulting pointer is only valid under RCU lock as well. > > Fix ath10k_wmi_tlv_op_pull_peer_stats_info() to hold RCU lock before it > calls ieee80211_find_sta_by_ifaddr() and release it when the resulting > pointer is no longer needed. > > This problem was found while reviewing code to debug RCU warn from > ath10k_wmi_tlv_parse_peer_stats_info(). > > Link: https://lore.kernel.org/linux-wireless/7230c9e5-2632-b77e-c4f9-10eca557a5bb@linuxfoundation.org/ > Signed-off-by: Shuah Khan > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 09078368d516 ath10k: hold RCU lock when calling ieee80211_find_sta_by_ifaddr() -- https://patchwork.kernel.org/project/linux-wireless/patch/20210210212107.40373-1-skhan@linuxfoundation.org/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches