Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <841a853821eb13029ec23b9d877ff0210c8e46b3.camel@coelho.fi>
From:   Luca Coelho <luca@coelho.fi>
To:     Kalle Valo <kvalo@codeaurora.org>
Cc:     linux-wireless@vger.kernel.org
Date:   Thu, 11 Feb 2021 22:25:25 +0200
In-Reply-To: <87sg62shgk.fsf@codeaurora.org>
References: <iwlwifi.20210211015026.289084803334.Ie234805047df3be84f4235f9dafaf4cdecf0db9a@changeid>
         <87sg62shgk.fsf@codeaurora.org>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [PATCH v2] iwlwifi: pnvm: implement reading PNVM from UEFI
Precedence: bulk

On Thu, 2021-02-11 at 18:21 +0200, Kalle Valo wrote:
> Luca Coelho <luca@coelho.fi> writes:
> 
> > From: Luca Coelho <luciano.coelho@intel.com>
> > 
> > We now support fetching the PNVM data from a UEFI variable.  Add the
> > code to read this variable first and use it.  If it's not available,
> > we fall back to reading the data from the filesystem, as before.
> > 
> > Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> 
> [...]
> 
> > --- a/drivers/net/wireless/intel/iwlwifi/fw/pnvm.c
> > +++ b/drivers/net/wireless/intel/iwlwifi/fw/pnvm.c
> > @@ -10,6 +10,7 @@
> >  #include "fw/api/commands.h"
> >  #include "fw/api/nvm-reg.h"
> >  #include "fw/api/alive.h"
> > +#include <linux/efi.h>
> >  
> > 
> > 
> > 
> >  struct iwl_pnvm_section {
> >  	__le32 offset;
> > @@ -219,6 +220,88 @@ static int iwl_pnvm_parse(struct iwl_trans *trans, const u8 *data,
> >  	return -ENOENT;
> >  }
> >  
> > 
> > 
> > 
> > +/*
> > + * This is known to be broken on v4.19 and to work on v5.4.  Until we
> > + * figure out why this is the case and how to make it work, simply
> > + * disable the feature in old kernels.
> > + */
> > +#if defined(CONFIG_EFI)
> 
> The comment doesn't really make sense anymore, can you send a followupb
> patch to remove it? No need to change the tag because of this.

Ugh, sorry about that.  I just saw that the version check had slipped
in and fixed it quickly at 2am, so I could still send you the pull-req
before going to sleep...

I'll send a patch removing this now.

--
Cheers,
Luca.