Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210115092405.8081-1-pkshih@realtek.com> <20210115092405.8081-4-pkshih@realtek.com>
 <CA+ASDXPtwyZMByRDaAQv9b-DEBeRgPxpDz4+mCP-zi6P_-zr7w@mail.gmail.com>
 <d84e1a2c0d8e481588eec7248abf5c1a@realtek.com> <CA+ASDXM7e4eSiJNoVMES7=mZ3M-NGpVZ9jLbjNm4yqMSYH4r+Q@mail.gmail.com>
 <e8e451faf35e47b494f6d49fe92d1858@realtek.com> <1612855085.8436.15.camel@realtek.com>
In-Reply-To: <1612855085.8436.15.camel@realtek.com>
From:   Brian Norris <briannorris@chromium.org>
Date:   Thu, 11 Feb 2021 12:30:21 -0800
Message-ID: <CA+ASDXO6ASrx1JiNo22HkOVsECw6J9++snqeGGpUiNz3OBg+Cw@mail.gmail.com>
Subject: Re: [PATCH v4 3/8] rtw88: add napi support
To:     Pkshih <pkshih@realtek.com>
Cc:     "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "tony0620emma@gmail.com" <tony0620emma@gmail.com>,
        "kvalo@codeaurora.org" <kvalo@codeaurora.org>,
        Bernie Huang <phhuang@realtek.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Feb 8, 2021 at 11:19 PM Pkshih <pkshih@realtek.com> wrote:
> Then, I have another simple thinking -- enable NAPI only if interrupt is
> enabled. Other operations with RX ring are working only if interrupt is
> disabled. So, we don't need a lock to protect RX ring at all.

That makes more sense; thanks for the update.

> The irq_lock is still used to protect TX ring/queue, and now it also used
> to protect switching IMR. Some comments are added to describe about this.
>
> Above is implemented in v5.

I've taken a brief look, and that looks better. I'll likely provide my
Reviewed-by there.

Thanks,
Brian