Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2716532pxb; Thu, 11 Feb 2021 22:15:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJzl7gTHHWO6Er6T318IV0ge9N8rkw7AKieSq1UbtaVGUjaEwuLgSJcAGEsbyrzCy0OXXXuJ X-Received: by 2002:a17:906:4f96:: with SMTP id o22mr1398679eju.511.1613110552668; Thu, 11 Feb 2021 22:15:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613110552; cv=none; d=google.com; s=arc-20160816; b=TPFW0PVnQew4S//iGi/3SbFm6u/OhYJm8ym2lWCMnjwbZRLiDt4NJWSuILncQy6Zj9 34hTmyqxImkoTmcJiO/EkgxjGR0jAF5xiPJWWUyTn26ntg5mCnv94kuPlrAlNWAaU8EG 9wygcohW45HLv+0RV990WVzUM7YIJaHCSn+lLeA+r6J3lip1Wun7NJ1cAeBQonbOJdjy n6vaO4DoQaWLW4owUF3fQEf0eGIDPSRUppbgOGgFccoxCEBD96cSl1mFuE6MVzSDRHUe lYwzUskBzeYu44sDoT/09CGkdWmaySpYVBWRF722Jy2SkAzkRFvnObunaWCf1i06L5JA LEkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dmarc-filter:sender :dkim-signature; bh=NS+j9B8F4UbvzG79z6s402dP/vEhbKM4061Z8Tc+74w=; b=AYw7ItZkL5ms97Fw5VkLVzLXtU7pFQ9AWJ0R0FvGFZVcMtmWonJtuekNwokjiF0Hap NOd4+pkIV9SXEkabOe39tU9kCOvilm6ExA/hx5ZwLiaNCX4l4gfps5BG5TUsCjjsNhsm 66b/en/Aq1uxCnYM4m38fyGWIUFZyBuMQhdspYRsK9AhP9TEZQmCPIThTPiWY6Da23w2 pioykPmwuwXKAc2jSNgAU+EzY0nhsj24Zgkm3pzkyeTpzlRP2zonjdUWbL2x+Cvdg9W3 L6l552YVSCC7eziiRIrt8xz4PmMFSuUoFvaX6oYf2CO7ew0h1cES6wxZSMD8BpY3IvPP Zgog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=oglDq3B3; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m5si91465ejk.585.2021.02.11.22.15.26; Thu, 11 Feb 2021 22:15:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=oglDq3B3; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229706AbhBLGMy (ORCPT + 99 others); Fri, 12 Feb 2021 01:12:54 -0500 Received: from so15.mailgun.net ([198.61.254.15]:38191 "EHLO so15.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229701AbhBLGMr (ORCPT ); Fri, 12 Feb 2021 01:12:47 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1613110349; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=NS+j9B8F4UbvzG79z6s402dP/vEhbKM4061Z8Tc+74w=; b=oglDq3B3eyCLPtqwUuGpGdUHBGAV+7kUcW5xA0Drxh/6fJ55hlLtc0Di6iIJi4M3sFKBUwep PBOnfEjyUs+sPGoiTz/JtEfkwHCLL7S9+zaw1mzaaSAyrH7b/9TiGsLza5IGuAJPvVGrBMzM TqLqoH6r7jat8uBchjmcEkrvZ0U= X-Mailgun-Sending-Ip: 198.61.254.15 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n07.prod.us-east-1.postgun.com with SMTP id 60261c2be4842e91289980e1 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 12 Feb 2021 06:11:55 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 1D3CAC433ED; Fri, 12 Feb 2021 06:11:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00,SPF_FAIL, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 74E4FC433CA; Fri, 12 Feb 2021 06:11:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 74E4FC433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Luca Coelho Cc: linux-wireless@vger.kernel.org Subject: Re: [PATCH] iwlwifi: remove incorrect comment in pnvm References: Date: Fri, 12 Feb 2021 08:11:51 +0200 In-Reply-To: (Luca Coelho's message of "Thu, 11 Feb 2021 22:30:55 +0200") Message-ID: <87o8gpstlk.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Luca Coelho writes: > From: Luca Coelho > > We use this driver as a backport that also runs on older kernels (as > part of the backports project). So we use some checks to backport or > prevent code from compiling in incompatible kernel version. > > When I took one of the PNVM patches from the backport, I accidentally > left the comment that a certain part of the code doesn't work in older > kernels. This obviously should never be valid for the mainline. > Remove this comment. > > Reported-by: Kalle Valo > Signed-off-by: Luca Coelho Thanks, I assigned this to myself on patchwork and apply directly to wireless-drivers-next. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches