Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2755961pxb; Thu, 11 Feb 2021 23:49:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJwwpYob2A5fuvHAi2I0EK0FUR1PFUEDRWMDk/DL2CwcvOd6XmRybiWASrsI0GXZIANmz1m1 X-Received: by 2002:a05:6402:278a:: with SMTP id b10mr2078099ede.347.1613116165508; Thu, 11 Feb 2021 23:49:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613116165; cv=none; d=google.com; s=arc-20160816; b=DGgx03kWQdEpTJNj31FTEzmkriNBz2RD0418skXyym9swWO1IzIa+DQYCYaxWKU5wU Birva6LkX5FGepTwUC62MLEBgAH4YdUTLLd+1YisA8Dvke2IFBz6olOKLmMjJv0lrgA1 JL+rKBeV7F/4GSC3v8TlplnYmZAMWg0pABfmnnWzzeds8Is4eVomTLuvmXdaHkKi9V2i tFn/FdmpXpSm5G+CxQGPl2Nf26czN/uhX4vWBKtenJbt+Mdzl1CrZV/IB5Wh2vGPqUUe U/1ahasNaqUsduE2ZFFGFZ+WCdqI3LAusKsie1bCH+VudxXtCUvdPBjzXDEkOrL+8RX8 vGNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dmarc-filter:sender:dkim-signature; bh=vm0EATJ1RNCjtHSDsiLFvakaGudSqDJpL8m06Bm4kD0=; b=ZYQwhv0FUpPrPe0qT6UB/HbFxAmUWSkF+JlSuuwfgwyLBlzCfwv4nkF3Y9aRDONccw eVGBWBw04bMZuD9eOgPjWv0NMqv7JJxjt0mIuFOoFOevnNvrCdOZKmyegW0KEuNd7wAH m19Q3GjVL0iqXrT1CF98ZxdtOaBGjI/Q2427xaogPhtlF9nkOqZcsfK2g0dX8DtI2OuP JkcDgguyEYVkSNUlP8+IWzJmr97ixemj2ohBdH1yo82hvJAWT1VSDqxP1DBzNkAESeiT 0E5Gp2Yjsrm+ZNlb08UDZfJkR8uk6Xx7NgYMNxhKZBVmoXzU3n0A46+Fq2zAVeG2qydA Drsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=AcYLb89S; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gt36si5431415ejc.57.2021.02.11.23.49.02; Thu, 11 Feb 2021 23:49:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=AcYLb89S; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229890AbhBLHsi (ORCPT + 99 others); Fri, 12 Feb 2021 02:48:38 -0500 Received: from so15.mailgun.net ([198.61.254.15]:14228 "EHLO so15.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229928AbhBLHrv (ORCPT ); Fri, 12 Feb 2021 02:47:51 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1613116051; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=vm0EATJ1RNCjtHSDsiLFvakaGudSqDJpL8m06Bm4kD0=; b=AcYLb89SuZpRVOudYFy/u+Vh+ZdLxmHUShwZdJVtJp8qroVSkFM6Fg8Bnrt9HUiAByF5ty10 6tmBO2Sn5c0PqS51GW47CZLKX+C5PYrQMAlwPktytEwlk1q1rZTrvFS+LLirb9vKNx3H1ccg uTF0Yi/dwNeq3xsrjKFlKgBuQD4= X-Mailgun-Sending-Ip: 198.61.254.15 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-east-1.postgun.com with SMTP id 60263275e3df861f4bc553f9 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 12 Feb 2021 07:47:01 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 17A3DC43461; Fri, 12 Feb 2021 07:47:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,BAYES_00, MISSING_DATE,MISSING_MID,SPF_FAIL,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id E282DC433CA; Fri, 12 Feb 2021 07:46:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E282DC433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] iwlwifi: remove incorrect comment in pnvm From: Kalle Valo In-Reply-To: References: To: Luca Coelho Cc: linux-wireless@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20210212074701.17A3DC43461@smtp.codeaurora.org> Date: Fri, 12 Feb 2021 07:47:01 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Luca Coelho wrote: > From: Luca Coelho > > We use this driver as a backport that also runs on older kernels (as > part of the backports project). So we use some checks to backport or > prevent code from compiling in incompatible kernel version. > > When I took one of the PNVM patches from the backport, I accidentally > left the comment that a certain part of the code doesn't work in older > kernels. This obviously should never be valid for the mainline. > Remove this comment. > > Reported-by: Kalle Valo > Signed-off-by: Luca Coelho Patch applied to wireless-drivers-next.git, thanks. 3304b6f937a3 iwlwifi: remove incorrect comment in pnvm -- https://patchwork.kernel.org/project/linux-wireless/patch/iwlwifi.20210211223049.40d545a0fa89.I04793aaa5312b926335c8db32131f000432df511@changeid/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches