Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2877678pxb; Fri, 12 Feb 2021 03:54:46 -0800 (PST) X-Google-Smtp-Source: ABdhPJyc1G5sBu9r03WnCClXZCjstOaLkbfT708zfrnvLLs/n5TQ/xmKAiCGoXUMD1o+cKyF3TAC X-Received: by 2002:a17:906:a106:: with SMTP id t6mr2662899ejy.63.1613130886172; Fri, 12 Feb 2021 03:54:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613130886; cv=none; d=google.com; s=arc-20160816; b=LrGW8vQkKM84N5jg9aDJBRJT3x4syA6LzCJikhfjWe57NtehTemotBw2KE4U9+Pwdp pSbVDzJBYutSdzhhoCDLbKoT99Pnz9j/MmCHb9tZJMI3H7Nz/NYygS6O64pyc1INF+Ot pdXyE+R5eRhMvLir/Qwv742kEaWMcThBlFgRkq9rs10Vs6iowkQW4PMDl5XHP0cRjgAE NEmaVZ4ZHxGrWjikn2eOVe5klzbK0nmVvmHvTFmILNw1HHp3uorpIzVh4Cm6qx48CoQE aohLJi+S8bTYCWKvW6K3otoCXl2nh983Z/0Ke9A8jSVwvurJ4JgzTimJxiooZzpaLcWy cueA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=PFBqzt2lprXEuM2ogIjz1sTuAtDz3uK3HKshqogSmY4=; b=K+oLmo5c1u3bvaxzQjil8RBwr9FyfeF9xzage705eZ2qbm7w1kyC7aK/KqRP5WC6Wi SZE5J9Dk+YKe+xnAtXKmE644ZByPrUCx0vivVe5X/gAt/r0ZwNYt4dMc0yKYCdk+Tgca qcR4yO4C5aimi1uI7z3EN4+TCDc4F52dvJ647ff7Z6fcmmRvIyFuDLSQcGSg9jOPVPEC BYKV2MCznxrCOjy0auuT5iTu9rVfNan4RNAD63oxBVZvkpYyDHf5XgQy55vX01T/J4iH xj3hBT8n5B0b4NeAkmxrcGrNWnqtFCpmsom2gBKsc4/6CWXlL8S5TmmCoBiYccnamebU BkWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Uo8BC7w4; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n19si5515194ejb.295.2021.02.12.03.54.23; Fri, 12 Feb 2021 03:54:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Uo8BC7w4; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229907AbhBLLvz (ORCPT + 99 others); Fri, 12 Feb 2021 06:51:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:47280 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229959AbhBLLvx (ORCPT ); Fri, 12 Feb 2021 06:51:53 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0020764E85; Fri, 12 Feb 2021 11:51:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613130672; bh=uvpfCLHunoPm0eUM2Xv0PxdIzJSLvY49OggW2BdxaPs=; h=From:To:Cc:Subject:Date:From; b=Uo8BC7w4LYDnn9VvL964WZBLHu8NTIW1Ec8jf2uCjEu03f0bZ/9XUY/e0zmYFYT6R TQj1iDDPCpthFRq34q9ci/QbR1RTeBBrwr2BmLyvMIt29wzzuBe3Bylw3TPuXONFFU yW6qThkpEy1XsACSD7c+uO91cmtr8qCReo+LL+hXoE5ymEqo8n05jooUX+3svjGWGv LDnvggZy2EKlPnI0qBvFvswZc1wNOsL7Lfn7Dw6NIHf6XKx9k8GxL+SyIjLjcU/7oT Ml/QLY+atHvlDMz/bEpmr7qpUU+cuXvldUiUU8zrffQlSS/3L+0NyXM30Zpscv6Opg Lbi09eBEWLeWA== From: Lorenzo Bianconi To: nbd@nbd.name Cc: linux-wireless@vger.kernel.org, dan.carpenter@oracle.com, lorenzo.bianconi@redhat.com Subject: [PATCH] mt76: connac: always check return value from mt76_connac_mcu_alloc_wtbl_req Date: Fri, 12 Feb 2021 12:51:05 +0100 Message-Id: X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Even if this is not a real bug since mt76_connac_mcu_alloc_wtbl_req routine can fails just if nskb is NULL , always check return value from mt76_connac_mcu_alloc_wtbl_req in order to avoid possible future mistake. Reported-by: Dan Carpenter Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/mt7615/mcu.c | 3 +++ drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c index 7e0046a20143..4e826acd7843 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c +++ b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c @@ -1032,6 +1032,9 @@ mt7615_mcu_sta_ba(struct mt7615_dev *dev, wtbl_hdr = mt76_connac_mcu_alloc_wtbl_req(&dev->mt76, &msta->wcid, WTBL_SET, sta_wtbl, &skb); + if (IS_ERR(wtbl_hdr)) + return PTR_ERR(wtbl_hdr); + mt76_connac_mcu_wtbl_ba_tlv(&dev->mt76, skb, params, enable, tx, sta_wtbl, wtbl_hdr); diff --git a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c index 3d139ecff84e..06111ef6f398 100644 --- a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c +++ b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c @@ -833,6 +833,9 @@ int mt76_connac_mcu_add_sta_cmd(struct mt76_phy *phy, wtbl_hdr = mt76_connac_mcu_alloc_wtbl_req(dev, wcid, WTBL_RESET_AND_SET, sta_wtbl, &skb); + if (IS_ERR(wtbl_hdr)) + return PTR_ERR(wtbl_hdr); + if (enable) { mt76_connac_mcu_wtbl_generic_tlv(dev, skb, vif, sta, sta_wtbl, wtbl_hdr); -- 2.29.2