Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 87A4FC43462
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Anilkumar Kolli <akolli@codeaurora.org>
Cc:     ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 11/11] ath11k: add qcn9074 pci device support
References: <1612946530-28504-1-git-send-email-akolli@codeaurora.org>
        <1612946530-28504-12-git-send-email-akolli@codeaurora.org>
Date:   Tue, 16 Feb 2021 18:36:48 +0200
In-Reply-To: <1612946530-28504-12-git-send-email-akolli@codeaurora.org>
        (Anilkumar Kolli's message of "Wed, 10 Feb 2021 14:12:10 +0530")
Message-ID: <87mtw4q89r.fsf@codeaurora.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Anilkumar Kolli <akolli@codeaurora.org> writes:

> QCN9074 is PCI based 11ax radio.
> 	- has 2G/5G/6G variants.
> 	- has NSS 2x2 and 4x4 variants.
>
> QCN9074 uses 45MB of HOST DDR memory, target requests host memory in
> segments, each segment is of 2MB size and is physcial contiguous and
> use static window configuration.
>
> Below QMI issues are seen with QCN9074,
> Issue 1:
>  ath11k_pci 0000:06:00.0: qmi failed memory request, err = -110
>  ath11k_pci 0000:06:00.0: qmi failed to respond fw mem req:-110
> Issue 2:
>  ath11k_pci 0000:06:00.0: firmware crashed: MHI_CB_SYS_ERROR
>  ath11k_pci 0000:06:00.0: qmi failed set mode request, mode: 0, err = -110
>  ath11k_pci 0000:06:00.0: qmi failed to send wlan fw mode:-110

I clarified the commit log to mention that QCN9074 is not fully working
yet.

> Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.4.0.1.r2-00012-QCAHKSWPL_SILICONZ-1
>
> Signed-off-by: Anilkumar Kolli <akolli@codeaurora.org>
> ---
>  drivers/net/wireless/ath/ath11k/pci.c | 20 ++++++++++++++++++--
>  1 file changed, 18 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath11k/pci.c b/drivers/net/wireless/ath/ath11k/pci.c
> index 70dcb80475b1..259a39e59a91 100644
> --- a/drivers/net/wireless/ath/ath11k/pci.c
> +++ b/drivers/net/wireless/ath/ath11k/pci.c
> @@ -34,10 +34,12 @@
>   */
>  #define ACCESS_ALWAYS_OFF 0xFE0
>  
> -#define QCA6390_DEVICE_ID		0x1101
> +#define QCA6390_DEVICE_ID              0x1101

Here you convert tabs to spaces, I fixed them back.

> +#define QCN9074_DEVICE_ID              0x1104

And modified this to use tabs as well.

>  static const struct pci_device_id ath11k_pci_id_table[] = {
>  	{ PCI_VDEVICE(QCOM, QCA6390_DEVICE_ID) },
> +	{ PCI_VDEVICE(QCOM, QCN9074_DEVICE_ID) },

I removed this and added a comment instead. Let's add the pci id once
the device is fully working.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches