Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 18 Feb 2021 09:13:24 +0100
From:   Stanislaw Gruszka <stf_xl@wp.pl>
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc:     kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iwlegacy: 4965-mac: Simplify the calculation of variables
Message-ID: <20210218081324.GA68220@wp.pl>
References: <1613632814-37897-1-git-send-email-jiapeng.chong@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1613632814-37897-1-git-send-email-jiapeng.chong@linux.alibaba.com>
Precedence: bulk

On Thu, Feb 18, 2021 at 03:20:14PM +0800, Jiapeng Chong wrote:
> Fix the following coccicheck warnings:
> 
> ./drivers/net/wireless/intel/iwlegacy/4965-mac.c:2596:54-56: WARNING !A
> || A && B is equivalent to !A || B.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  drivers/net/wireless/intel/iwlegacy/4965-mac.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/intel/iwlegacy/4965-mac.c b/drivers/net/wireless/intel/iwlegacy/4965-mac.c
> index 28675a4..52db532 100644
> --- a/drivers/net/wireless/intel/iwlegacy/4965-mac.c
> +++ b/drivers/net/wireless/intel/iwlegacy/4965-mac.c
> @@ -2593,8 +2593,7 @@ struct il_mod_params il4965_mod_params = {
>  	 */
>  	if (ret != IL_INVALID_STATION &&
>  	    (!(il->stations[ret].used & IL_STA_UCODE_ACTIVE) ||
> -	     ((il->stations[ret].used & IL_STA_UCODE_ACTIVE) &&
> -	      (il->stations[ret].used & IL_STA_UCODE_INPROGRESS)))) {
> +	      (il->stations[ret].used & IL_STA_UCODE_INPROGRESS))) {
>  		IL_ERR("Requested station info for sta %d before ready.\n",
>  		       ret);
>  		ret = IL_INVALID_STATION;

This patch was already applied to wireless-drivers-next.

Stanislaw