Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp8190464pxb; Fri, 19 Feb 2021 09:32:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJwnOHtG4e0qUvZ2+Sfju+y03QnvVddu/iX89QaaGN75V04K6rIkAX5scJCI+StRa7XBhGSh X-Received: by 2002:a17:906:9144:: with SMTP id y4mr5250613ejw.270.1613755926261; Fri, 19 Feb 2021 09:32:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613755926; cv=none; d=google.com; s=arc-20160816; b=CshxzJSzciqD+hAuZ7f8RiqgssfeKYNac/2w5axYO7YzP7vno3l74+tBocqrNvWmGJ Q/gCAfPc11Go1BW5aOERzXC6RF5c5Qq0F1yUB0T1IPFUh6Ka1GWo3vCRlmfQ/b+9PFKd DUgk9khegxdsMgUMVN7cPoJEprEIU9L09UQWvk/9c/iX00Z/iDaQxGmcDETgFi/Ozp9k 3YA06MiUWvrHim4pxPnBHnsFVXtQkZoCY9p6oBY4422pVXDcNn9lWwiNzyucgwJoGyFy oyRf6lpSv8RWFLRn6y77S2TBYBRr4HPfGaPMUeajM+JKhYNwo1iTgVhG+zhnmCA2akQn mkxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=DGGQtu9SN150VPK3FpvMSN13R7MrG++Qbg0pYwqmJ7s=; b=sdGSOyAIavXPXvoIpseWZR9S9YuCm1UJKFEj9AvNm6Fb/85cs3z43iRg4i3OvqRkmC jITT1V4sjrSPp14kVpMD5yjUzwjJdIeeMVe5LhNhvt8Sofck5eHbr4+wX/yf8bYqVjpE wUZ5Fq6vSjAozESIcpPQM419KHsfwfoxMdolDs8DWzfGVwIu0KQxHov7qaqhedFNUrJ/ RN4v1OvSgmtBcYCiJa4DRom0BWw6ZwULt4nlIEc5Z6niLztGRDqVa0tb+LHw1MZ0tgfD LGiswzlUw1euGWWXhUg0/s4AF/2MLe+lVLwLakDJ3KcbYtsjsTyKndZr1jPtALWNv8/m lQtQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qMmHQSYl; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s9si6391947edr.275.2021.02.19.09.31.42; Fri, 19 Feb 2021 09:32:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qMmHQSYl; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229683AbhBSR3z (ORCPT + 99 others); Fri, 19 Feb 2021 12:29:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:35648 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229527AbhBSR3x (ORCPT ); Fri, 19 Feb 2021 12:29:53 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8FB7C64E92; Fri, 19 Feb 2021 17:29:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613755752; bh=kdPuPJVVjL5SudYMyG5MAw+/bnFudTIECAVlKbbrWf8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qMmHQSYltIq6hC21XcT+53w3EQ/OkBrLG2b2pDD/EtYJaADg2s6qBGjECUXXbzIeG 8B1c4zIAUxWI9SVQygDsUJ987cw0/I0+sbGF2BvD5I1KTxc3yVKX5hj7E/NCuFk2xK nnas8Y9JjhbqxB40RtTDEJxTXNpRlWX71e3j9uQpjT3UsOpjtS+s5rac7FUNdlYeYs 2s3bNcGvevd+F5mmJ/+OseYymI0RC/Znf8fQjlJhmDs36F5Rj9f3OmLulbvlSSjOAE j4DXTLQCbvMh10Q8CsmFdDrOo+pPVz20V7kxH6LywOITzDorlL98ZtcFAuNvkxyskL pmAuVNYbsI4yg== From: Lorenzo Bianconi To: nbd@nbd.name Cc: linux-wireless@vger.kernel.org, lorenzo.bianconi@redhat.com, sean.wang@mediatek.com Subject: [PATCH v2 2/8] mt76: mt7921: fix memory leak in mt7921_coredump_work Date: Fri, 19 Feb 2021 18:28:45 +0100 Message-Id: <611f3f56d715a11a12e8144175d3fb8b652588a6.1613755428.git.lorenzo@kernel.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Sean Wang Fix possible memory leak in mt7921_coredump_work. Fixes: 1c099ab44727c ("mt76: mt7921: add MCU support") Signed-off-by: Sean Wang Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/mt7921/mac.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mac.c b/drivers/net/wireless/mediatek/mt76/mt7921/mac.c index 9468c9c3b9cf..8befa8167cde 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7921/mac.c +++ b/drivers/net/wireless/mediatek/mt76/mt7921/mac.c @@ -1503,8 +1503,10 @@ void mt7921_coredump_work(struct work_struct *work) break; skb_pull(skb, sizeof(struct mt7921_mcu_rxd)); - if (data + skb->len - dump > MT76_CONNAC_COREDUMP_SZ) - break; + if (data + skb->len - dump > MT76_CONNAC_COREDUMP_SZ) { + dev_kfree_skb(skb); + continue; + } memcpy(data, skb->data, skb->len); data += skb->len; -- 2.29.2