Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp8281851pxb; Fri, 19 Feb 2021 12:00:14 -0800 (PST) X-Google-Smtp-Source: ABdhPJyYbLn9JgYB/KuOGt4+ZixL6z6VzNc0xxsYxhd8oZGF+PwcgqOHWWjer/8Gc+wlM4+EEEeC X-Received: by 2002:a17:906:ccd8:: with SMTP id ot24mr10466837ejb.46.1613764814606; Fri, 19 Feb 2021 12:00:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613764814; cv=none; d=google.com; s=arc-20160816; b=fcJ+yHsWoNiVwS4waVEjpR28T/Xbj83eCfl8TISxwR5v2KUPu1JXPb3TipQ46ZTGJO lBb2A+CZcyZDUBsFlJo7XbMzwiSn75xLtXRMXOq7adOkwLQPsxnGZ+FBipdG2NVlIOHq rkyPCqUy2okWDsMeIDc5O/qL3pADNpwxYrnOJqOey2jDDAY1s48vJDv0AtdRhcn4o8me O/v52KdvuAu7HL3avzZ7NI1SF2IB4qkedB36syou9mvC2pEmuDLcChXICDPBff9RxK3a TKLBP5tZBAwfY+4GdF4gbDIL+0Xd6l/H+kJ0xvjIVILi/7wZPXBzgrDQBfuVsioZBpDl h0gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:message-id; bh=qpo+u/mKTfg6KVPdvGH/4NFCmlf1yuQG7tQ4OOzkKdU=; b=BDmjJFM02juEhs1xr9ip+cJgpsipbJWcGjfb7GUlIxAL16VhSrqKhDxo3IaHazqbZU ObZm5NgJ/hx5yPuuTBv2kNMHg3YYd6fCSLTxgiA1GRd7F+06CsyqmOX3GSMksGUCGp1e yKp5A1NRNOGXpShQ3wPGInvsTFPMiGpmTwR9CHDTTPDKLvmMx5pd+p4kj0CZgq3NLxW6 TgFydd0rcPES4vBbW5PqvS/K0iJruVVi5WPzeRn7zUlSxxkkw/c2Tu/AAmkS4ASWQ0Dz mc05hnejMzuVOhJJ+JkJ6comiHPqrCiCB+o07Ao7hO7Mi7IIJEJQXjQqeBU+uhzjNaQQ Iqmw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id eb8si8317400edb.6.2021.02.19.11.59.16; Fri, 19 Feb 2021 12:00:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229683AbhBST7F (ORCPT + 99 others); Fri, 19 Feb 2021 14:59:05 -0500 Received: from paleale.coelho.fi ([176.9.41.70]:46412 "EHLO farmhouse.coelho.fi" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229555AbhBST7E (ORCPT ); Fri, 19 Feb 2021 14:59:04 -0500 Received: from 91-156-6-193.elisa-laajakaista.fi ([91.156.6.193] helo=[192.168.100.69]) by farmhouse.coelho.fi with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lDBug-004I4b-1Q; Fri, 19 Feb 2021 21:58:09 +0200 Message-ID: <5a81b6289a2242ae32b46f012aad2f94a232e595.camel@coelho.fi> From: Luca Coelho To: Kalle Valo , Johannes Berg Cc: linux-wireless@vger.kernel.org, Johannes Berg , Andy Lavr Date: Fri, 19 Feb 2021 21:58:03 +0200 In-Reply-To: <87eehcglgy.fsf@tynnyri.adurom.net> References: <20210219133506.ecabe285bc7d.I73d230d555c595fa2d9bf284f80078729fe18aa4@changeid> <87eehcglgy.fsf@tynnyri.adurom.net> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on farmhouse.coelho.fi X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, TVD_RCVD_IP autolearn=ham autolearn_force=no version=3.4.4 Subject: Re: [PATCH] iwlwifi: avoid crash on unsupported debug collection Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Fri, 2021-02-19 at 16:50 +0200, Kalle Valo wrote: > Johannes Berg writes: > > > From: Johannes Berg > > > > If the opmode doesn't support debug collection (DVM) then don't > > crash, but just skip the callback. > > > > Fixes: d01293154c0a ("iwlwifi: dbg: add op_mode callback for collecting debug data.") > > Reported-by: Andy Lavr > > Signed-off-by: Johannes Berg > > Should I take this to wireless-drivers? Yes, please take this to wireless-drivers. As Johannes said, this breaks all DVM (older) devices. -- Luca.