Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1642635pxb; Mon, 22 Feb 2021 07:19:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJwmQ8vceOaWhMRju3uS4BhACOFoUBFK4nq5Q1z3Yia4EchPE2X+bGhcfYU6TcS24RfjoJRf X-Received: by 2002:a17:906:3105:: with SMTP id 5mr21574716ejx.168.1614007151174; Mon, 22 Feb 2021 07:19:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614007151; cv=none; d=google.com; s=arc-20160816; b=0u68y6Wf8B4CzRO1jgGYI1emqFIVvfXeeG/XYp3dPbqtqMN9hKCUvfqWYkvF3PDJlG fffQyd27OCypDRANWknmjX8kLoaH53N56J0IGizLqglS+ky7djIH484tazsMB+UqXmd2 Zi0zku0ccmd+pM0Zyl6mNMU74euc88TlzxRvGfto0HZV4oEhLtvn1Cmvu+7Z5e/FYEgZ FsMHusWH3eNvqoqFkGB1pspMKTMis86gzFTyH5uqH2ubJUMe3JpVa+R9Wb1PkQMqL/pq awffV1iAieQuaYcMM1jr9vWJ6y8/gHqxCdFLs3L6oRU6O82D3s1Dsjd99iO6Akp90lnk Ws4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=LCvRPZEd90/xpsSd61z25FldTTbsUBQjwGTJ95IHlk8=; b=jngqh5NjGlcEu5BPm3X8U0pBv7LW3R7IHBWDaxrNP/UcDvN4SGS8rvwXGd6KtN6sX0 169i+raHrzThivUP7LvagK0v4yLmQ3AamVTaH+oCpbI2tSehXdvUG99Y/IY8xCyNtdhL FxQyZ5iQYuZ3KX6WOm0Hsj6QxgfCHhteIu4ywnK+N7SinoghCjR0+nRPOiFRZufjoTfy L/sq1oWmz+dPdN04KZbsx20vTb6nSpNsVd/j41jF+uHt6ZPlfa+lNLjjEt5QSr9LVEoJ IxsnJxsspvWVVSaz3oQ3ddpvbduhCpt01hafaW4rEyW6E+EOY3uNBCKTVOImtLtriOqx Fn5g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cf15si11159344ejb.302.2021.02.22.07.18.48; Mon, 22 Feb 2021 07:19:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231433AbhBVPPb (ORCPT + 99 others); Mon, 22 Feb 2021 10:15:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231276AbhBVPPF (ORCPT ); Mon, 22 Feb 2021 10:15:05 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA1A7C0611BC for ; Mon, 22 Feb 2021 07:12:59 -0800 (PST) Received: from dude.hi.pengutronix.de ([2001:67c:670:100:1d::7]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lECtF-0007dr-14; Mon, 22 Feb 2021 16:12:49 +0100 Received: from ore by dude.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1lECtE-0006zu-6X; Mon, 22 Feb 2021 16:12:48 +0100 From: Oleksij Rempel To: mkl@pengutronix.de, "David S. Miller" , Jakub Kicinski , Oliver Hartkopp , Robin van der Gracht , Johannes Berg Cc: Oleksij Rempel , kernel@pengutronix.de, linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Eric Dumazet , linux-wireless@vger.kernel.org Subject: [PATCH net v1 0/3] add support for skb with sk ref cloning Date: Mon, 22 Feb 2021 16:12:44 +0100 Message-Id: <20210222151247.24534-1-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::7 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-wireless@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Hello, this series tries to fix a long standing problem in the CAN echo SKB handling. The problem shows up if an echo SKB for a SKB that references an already closed socket is created. It looks like the mac80211/tx.c has the same problem, see RFC patch 3 for details. regards, Oleksij Oleksij Rempel (3): skbuff: skb_clone_sk_optional(): add function to always clone a skb and increase refcount on sk if valid can: fix ref count warning if socket was closed before skb was cloned [RFC] mac80211: ieee80211_store_ack_skb(): make use of skb_clone_sk_optional() include/linux/can/skb.h | 3 +-- include/linux/skbuff.h | 1 + net/can/af_can.c | 6 +++--- net/can/j1939/main.c | 3 +-- net/can/j1939/socket.c | 3 +-- net/can/j1939/transport.c | 4 +--- net/core/skbuff.c | 27 +++++++++++++++++++++++++++ net/mac80211/tx.c | 6 +----- 8 files changed, 36 insertions(+), 17 deletions(-) -- 2.29.2