Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <f929d047895ec8931064c0058f461a95b4b6f5dd.camel@egauge.net>
Subject: Re: wilc1000 driver
From:   David Mosberger-Tang <davidm@egauge.net>
To:     Ajay.Kathat@microchip.com, linux-wireless@vger.kernel.org
Date:   Tue, 23 Feb 2021 11:06:53 -0700
In-Reply-To: <b7c1b271-993b-064e-3c2a-74302744edd8@microchip.com>
References: <e8ed97f214f6087b7ac59298c8efe2d1144f7d55.camel@egauge.net>
         <eb6c6b39-f168-7237-d220-585f99532fd9@microchip.com>
         <f3e0540462ed8bcc59787f71e3b1b258945a6142.camel@egauge.net>
         <5fc9c8ad5d93e2172f03515f8275851af285a895.camel@egauge.net>
         <b7c1b271-993b-064e-3c2a-74302744edd8@microchip.com>
Organization: eGauge Systems LLC
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.4-0ubuntu1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 2021-02-23 at 17:19 +0000, Ajay.Kathat@microchip.com wrote:
> Hi David,
> 
> On 23/02/21 9:53 pm, David Mosberger-Tang wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> > 
> > OK, the problem below is caused by wilc_set_power_mgmt().  If I change
> > that function into a no-op, the driver actually works!  Does this make
> > any sense to you?  From what I saw so far, it looks like relevant code
> > is pretty much identical to the one in the linux-at91 tree and that one
> > works fine.
> > 
> 
> As I understand you are testing with default powersave mode enabled. One
> approach could be to disable the default powersave mode by compiling
> with CFG80211_DEFAULT_PS disabled. When its disabled, .set_power_mgmt cb
> is called with powersave disable.
> If the powersave mode is enabled, the chip need to be wakeup by
> following the wakeup sequence. We need to bring in chip_wake() API
> changes, to set registers specific for WILC1000. I have plans to port
> these changes to support PSM mode but it will take few weeks.

Indeed.  Sure, I'll just compile with powersave mode disabled for now
until you've had a chance to bring forward the missing pieces.

Thanks!

  --david