Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <33012e779ee172e688cac2e710fa1ddab68fc611.camel@egauge.net>
Subject: Re: [PATCH 4/4] wilc1000: Add support for enabling CRC
From:   David Mosberger-Tang <davidm@egauge.net>
To:     Ajay.Kathat@microchip.com, linux-wireless@vger.kernel.org
Cc:     Claudiu.Beznea@microchip.com
Date:   Wed, 24 Feb 2021 08:47:50 -0700
In-Reply-To: <a4261e8e-3693-2aa0-e23a-3bd3c6eb5686@microchip.com>
References: <20210224055135.1509200-1-davidm@egauge.net>
         <20210224055135.1509200-4-davidm@egauge.net>
         <a4261e8e-3693-2aa0-e23a-3bd3c6eb5686@microchip.com>
Organization: eGauge Systems LLC
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.4-0ubuntu1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

Ajay,

On Wed, 2021-02-24 at 13:35 +0000, Ajay.Kathat@microchip.com wrote:
> 
> One more observation.
> I am not clear if the below block is really needed. Have you faced any
> issue here and did the below logic of skipping data helped to come out
> of it. Also checking the limit of 16384(2*8KB) byte looks odd when the
> max limit for data packet is around 8KB. Am I missing something here.
> 
> > +
> > +                               {
> > +                                       u8 byte;
> > +                                       int i;
> > +
> > +                                       for (i = 0; i < 16384; ++i) {
> > +                                               byte = 0;
> > +                                               wilc_spi_rx(wilc, &byte, 1);
> > +                                               if (!byte)
> > +                                                       break;
> > +                                       }
> > +                               }

Ouch, that's definitely not supposed to be there!  It's left-over debug
code from when I was tracking down the power-save issue.  Not sure how
I missed that.  Thanks for catching it and being so gentle about it! 

How do I fix this best?  Do I resend the entire patch series or is it
OK to create a V2 of just this last patch?


  --david