Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp546161pxb; Wed, 24 Feb 2021 08:41:21 -0800 (PST) X-Google-Smtp-Source: ABdhPJyQpibndcBTBPgtzL4cyEL/Cx6e5+7rTdNnSJ7w+durJcPRHj/iVZgWU6JG+ixilTEuEeUw X-Received: by 2002:a17:906:7697:: with SMTP id o23mr32599558ejm.292.1614184880801; Wed, 24 Feb 2021 08:41:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614184880; cv=none; d=google.com; s=arc-20160816; b=rkAjbpXtw5v703VF32epZlJl+9Wrbgc2ky6/Ial9gxbEyuglRTPwLvcRYKVwEE9Iu1 X57XeItaxB6qxGj/5QheJ0gvNradS6UoLbRzXDkgM9S1aMtBQb27a7QfDdcrP9xNZ+EN lDZUX4K3Xgr+qG4IJabGfoiY9yTvFewY4+WtqkFYBsOXRppl2rfgO4lAHNXOnRjHSfou Yy6BSp2s/4BIfo+jD0hLHt2jJaWTSDusXe6wpMqPkPm29HpgeN3rCH1TaTgol5YOSmMS de8855CrISaXvGq3Si7Rd+z/b9C3CZYFJ9vPyUgw9zH8M5woydKcF507yl89C4vg0nQx 8nyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=MVmZumu1MFGQXdL/ioPLeL2JHnOHtr9yLNDGu09SiDU=; b=vQ0zklPZ0DtJac898w+Zak++77KYhenzKtl3nj+nxxe6r3zN1JMSVW88Ge/VFRtkt0 xpTxWPR0p7qeT1z9vI1Qmhn3mtf8jyJHDvdlL1AkSqyLxp4i6OMmTpmEtOA/wyfueD/F NlavkJR6ZdkYHXABOVr7LqTlJG4rthTEzD+2q7LSYNIO45WRfWkMMDxSaXGk4LNPTqUp 224d1/E8JbXGTrvuobvL2lauhb/ahXZ1rDkBo9O69MBUkL+VAOYYHbKDqfBYrZJ6XkZK JR/Ls54WwnucrtrKizVyPnYCYLILELJFVCwSJSYjTRfL7/Q0bil16H8K/Y29F8eAU2At NVJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=pw5L1f3R; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y16si1410012edi.542.2021.02.24.08.40.57; Wed, 24 Feb 2021 08:41:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=pw5L1f3R; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234883AbhBXQiH (ORCPT + 99 others); Wed, 24 Feb 2021 11:38:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234826AbhBXQgF (ORCPT ); Wed, 24 Feb 2021 11:36:05 -0500 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9116EC061574; Wed, 24 Feb 2021 08:35:23 -0800 (PST) Received: by mail-wm1-x32d.google.com with SMTP id w7so2322915wmb.5; Wed, 24 Feb 2021 08:35:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=MVmZumu1MFGQXdL/ioPLeL2JHnOHtr9yLNDGu09SiDU=; b=pw5L1f3RLGOqplHvTDu852ma9AAsisWzlTmcgXbJQ9pIv9lusTz/QpJvx+qwUYTNPe Ns0ArGEg+i6MnThU+83EDMrQjAqN9I2AEKhlek+LzJBWrT4fhWPE0TN6ZwUG7n1a9Ejo 7RxFMYA5HO9HGGphWYvK/akpLOnJnbCsr804MD9LoLiO4eReezhPeVIkAYyOgIB9Qr4n fGmlRT+tnUVBvNAMBYI0Y/jp0UznSOGAhzRRDSr8ucR/EpgxaXN+YonRZoYLNWCNX2y/ 7y3Ftf3S0HldrxUL/0/kQYWqxKhgzkwA9D0lXIWKHJPox2ZQR38wKnDEJcPO0Ji3+pWs PsHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=MVmZumu1MFGQXdL/ioPLeL2JHnOHtr9yLNDGu09SiDU=; b=sbkwX2cLAkSYKH3TrjUGSapouJLL9fOtXDaJlMPSSJo41t69I1x8yf7KdvxTlqutQj TBqfnAGgpgfQr8D0LG6WX6LRGq0Wdz3q0HyTMdA0PbErMQnZGhfCAsRuP4o9aJMMbq0o 5BBMyUdKZIKvCwVSuRVVccfLWC7Tgmb7XNV3jLnuu+Gx42aFZuyIEwmX8+xb3FDEFV7r t7up4hdTY2HzUFMQMRFIho5M+EcXovWqnB/41nDjqn3VyT/SnAMJG8hesbLrsemUJhE1 XxlFfQ4uOlXU3hdVMQXTi9JAeXXVmwQdmNJ9nzRCRgOpa+sLXHSt5n1Q9YevfnoBY8re lEsQ== X-Gm-Message-State: AOAM533c6nnV1A5sOHu5LjYzUG2V0rvreX5HFyyE43jIilnn8YtGoBZR aXLdC6i7smpWUm52/nT6rZKN/2NEY09NDg== X-Received: by 2002:a05:600c:17d1:: with SMTP id y17mr4526397wmo.164.1614184522411; Wed, 24 Feb 2021 08:35:22 -0800 (PST) Received: from little.cd.corp (82-209-154-112.cust.bredband2.com. [82.209.154.112]) by smtp.gmail.com with ESMTPSA id 36sm5259254wrj.97.2021.02.24.08.35.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Feb 2021 08:35:21 -0800 (PST) From: Marcus Folkesson To: Ajay Singh , Claudiu Beznea , Kalle Valo , "David S . Miller" , Jakub Kicinski , Greg Kroah-Hartman Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Marcus Folkesson Subject: [PATCH] wilc1000: write value to WILC_INTR2_ENABLE register Date: Wed, 24 Feb 2021 17:37:06 +0100 Message-Id: <20210224163706.519658-1-marcus.folkesson@gmail.com> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Write the value instead of reading it twice. Fixes: 5e63a598441a ("staging: wilc1000: added 'wilc_' prefix for function in wilc_sdio.c file") Signed-off-by: Marcus Folkesson --- drivers/net/wireless/microchip/wilc1000/sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/microchip/wilc1000/sdio.c b/drivers/net/wireless/microchip/wilc1000/sdio.c index 351ff909ab1c..e14b9fc2c67a 100644 --- a/drivers/net/wireless/microchip/wilc1000/sdio.c +++ b/drivers/net/wireless/microchip/wilc1000/sdio.c @@ -947,7 +947,7 @@ static int wilc_sdio_sync_ext(struct wilc *wilc, int nint) for (i = 0; (i < 3) && (nint > 0); i++, nint--) reg |= BIT(i); - ret = wilc_sdio_read_reg(wilc, WILC_INTR2_ENABLE, ®); + ret = wilc_sdio_write_reg(wilc, WILC_INTR2_ENABLE, reg); if (ret) { dev_err(&func->dev, "Failed write reg (%08x)...\n", -- 2.30.0