Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <70567db1d625086e051b305320c9d4be7deb1b82.camel@egauge.net>
Subject: Re: [PATCH 4/4] wilc1000: Add support for enabling CRC
From:   David Mosberger-Tang <davidm@egauge.net>
To:     Julian Calaby <julian.calaby@gmail.com>
Cc:     linux-wireless@vger.kernel.org,
        Ajay Singh <ajay.kathat@microchip.com>,
        Claudiu Beznea <claudiu.beznea@microchip.com>
Date:   Wed, 24 Feb 2021 16:36:53 -0700
In-Reply-To: <CAGRGNgUR7wHgprWcqz5orJNuhcxeLMSE1C3WCi1_UH_MCwJ6Cg@mail.gmail.com>
References: <20210224055135.1509200-1-davidm@egauge.net>
         <20210224055135.1509200-4-davidm@egauge.net>
         <CAGRGNgUR7wHgprWcqz5orJNuhcxeLMSE1C3WCi1_UH_MCwJ6Cg@mail.gmail.com>
Organization: eGauge Systems LLC
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.4-0ubuntu1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

Julian,

On Thu, 2021-02-25 at 08:19 +1100, Julian Calaby wrote:
> Hi David,
> 
> On Wed, Feb 24, 2021 at 6:56 PM David Mosberger-Tang <
> davidm@egauge.net> wrote:
> > 
> > +#define ENABLE_CRC7    0       /* set to 1 to protect SPI commands
> > with CRC7 */
> > +#define ENABLE_CRC16   0       /* set to 1 to protect SPI data
> > with CRC16 */
> 
> Should these be Kconfig variables instead?

I'd certainly like that.  Ajay, would you be OK with that?

  --david