Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <b5749996ac7defbdb277bb3520467db707b905dc.camel@coelho.fi>
From:   Luca Coelho <luca@coelho.fi>
To:     Kalle Valo <kvalo@codeaurora.org>, linux-wireless@vger.kernel.org
Cc:     rdunlap@infradead.org
Date:   Thu, 25 Feb 2021 09:10:38 +0200
In-Reply-To: <1614236661-20274-1-git-send-email-kvalo@codeaurora.org>
References: <1614236661-20274-1-git-send-email-kvalo@codeaurora.org>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH 5.12] iwlwifi: pcie: fix iwl_so_trans_cfg link error
 when CONFIG_IWLMVM is disabled
Precedence: bulk

On Thu, 2021-02-25 at 09:04 +0200, Kalle Valo wrote:
> Randy reported an error on his randconfig builds:
> 
> ERROR: modpost: "iwl_so_trans_cfg" [drivers/net/wireless/intel/iwlwifi/iwlwifi.ko] undefined!
> 
> The problem was that when CONFIG_IWLMVM was disabled we were still accessing
> iwl_so_trans_cfg. Fix it by moving IS_ENABLED() check before the access.
> 
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
> ---

Thanks for the fix, Kalle! Please take it directly to wireless-drivers.

Acked-by: Luca Coelho <luciano.coelho@intel.com>

--
Cheers,
Luca.