Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1038231pxb; Fri, 26 Feb 2021 00:27:32 -0800 (PST) X-Google-Smtp-Source: ABdhPJwV/l/ktQ2WtaTJDAoWcf0lEvghj7Z5putVbPFiSD88PVgMe2pvZnREzRsGwTzAkeZNhWzr X-Received: by 2002:a05:6402:348c:: with SMTP id v12mr1988850edc.314.1614328052278; Fri, 26 Feb 2021 00:27:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614328052; cv=none; d=google.com; s=arc-20160816; b=sYBE+lKl1exyOI7Fqh21YtEA/YqCrSIWn6nEF9nVNs8VOoi+2m967QMh7g201t0sVP aLGedStBvrj2MJaCwsRA9AkU1bBvug7Fn22HC0mBe7xy2vhB1FmXKPRcPa7mXdsq1N1t VmKHJmYc+x3ae24lSI4XYujkdlzt91PrmzJRuFdeyNjM5dv/h9XVPh5pfbCqvhe9SBhR Ffe38wlHj7gKM9XNdtuidiTTCiyRcwBCsl6Frtimh0CTL+uxzQncVrAN+STEF4CWJWLK /bhw3ZPOJPWVWXnFYFhVx9Ej16DW6re5hLQ0++x6gTOHygdSp3IEN5VNaGqCUgFWpFtD 7mYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=QoyZsbsz7PsPDRucDV+2M1xTEK0YX85LNCqJCn1Q/RU=; b=xToG7nIS1GHB2yGWlFg7i3SYOpz0LE7tqWEh4AA3lwNpWHxwBQMDfnszvKgU9TvWIj 5qlbv7bTWxui7ewjvd1V/99mHq3iHAEJO/6ZsyeTPplu0n1s5bjKgE9iCoXON+qcbefZ 4RIsuTa3LYA5lrEosuc15e9/HMD9GwPvFFzWcsAIfyVt3JaBgk0mGo2T1XXltgKoO3JJ 1vlk381g5O16geRC7mf/r8p+YPfEKj+gSD39H6au/ldw9rd5mEF2Agg3UgIN7xNmvTre 2umTInFvEk/kON27VL/w1Mbs6Nbn+hPiiTcJXxQJGkpfWVwLVKfcVwbkrJwVrX2YFnSZ tvew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o18si5285681ejb.41.2021.02.26.00.27.07; Fri, 26 Feb 2021 00:27:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229590AbhBZIYS (ORCPT + 99 others); Fri, 26 Feb 2021 03:24:18 -0500 Received: from mailgw01.mediatek.com ([210.61.82.183]:58307 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S229498AbhBZIYR (ORCPT ); Fri, 26 Feb 2021 03:24:17 -0500 X-UUID: eafa2bf0c3b24652a05054dc14b88757-20210226 X-UUID: eafa2bf0c3b24652a05054dc14b88757-20210226 Received: from mtkcas10.mediatek.inc [(172.21.101.39)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.14 Build 0819 with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 2037189954; Fri, 26 Feb 2021 16:23:31 +0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 26 Feb 2021 16:23:29 +0800 Received: from mtkswgap22.mediatek.inc (172.21.77.33) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 26 Feb 2021 16:23:29 +0800 From: To: , CC: , , , , , , , , , Subject: [PATCH 1/2] mt76: mt7921: fix the base of PCIe interrupt Date: Fri, 26 Feb 2021 16:23:26 +0800 Message-ID: <4ff45223ff7ecff8e20a722ffd2db77fe51fea00.1614327185.git.objelf@gmail.com> X-Mailer: git-send-email 1.7.9.5 MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Sean Wang Should use 0x10000 as the base to operate PCIe interrupt according to the vendor reference driver. Fixes: ffa1bf97425b ("mt76: mt7921: introduce PM support") Co-developed-by: YN Chen Signed-off-by: YN Chen Signed-off-by: Sean Wang --- drivers/net/wireless/mediatek/mt76/mt7921/pci.c | 4 ++-- drivers/net/wireless/mediatek/mt76/mt7921/regs.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/pci.c b/drivers/net/wireless/mediatek/mt76/mt7921/pci.c index 3e430c04c97e..def8b7816609 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7921/pci.c +++ b/drivers/net/wireless/mediatek/mt76/mt7921/pci.c @@ -137,7 +137,7 @@ static int mt7921_pci_probe(struct pci_dev *pdev, mt76_wr(dev, MT_WFDMA0_HOST_INT_ENA, 0); - mt7921_l1_wr(dev, MT_PCIE_MAC_INT_ENABLE, 0xff); + mt76_wr(dev, MT_PCIE_MAC_INT_ENABLE, 0xff); ret = devm_request_irq(mdev->dev, pdev->irq, mt7921_irq_handler, IRQF_SHARED, KBUILD_MODNAME, dev); @@ -248,7 +248,7 @@ static int mt7921_pci_resume(struct pci_dev *pdev) return 0; /* enable interrupt */ - mt7921_l1_wr(dev, MT_PCIE_MAC_INT_ENABLE, 0xff); + mt76_wr(dev, MT_PCIE_MAC_INT_ENABLE, 0xff); mt7921_irq_enable(dev, MT_INT_RX_DONE_ALL | MT_INT_TX_DONE_ALL | MT_INT_MCU_CMD); diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/regs.h b/drivers/net/wireless/mediatek/mt76/mt7921/regs.h index 419add751980..c4bd31cc81cb 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7921/regs.h +++ b/drivers/net/wireless/mediatek/mt76/mt7921/regs.h @@ -391,7 +391,7 @@ #define MT_HW_CHIPID 0x70010200 #define MT_HW_REV 0x70010204 -#define MT_PCIE_MAC_BASE 0x74030000 +#define MT_PCIE_MAC_BASE 0x10000 #define MT_PCIE_MAC(ofs) (MT_PCIE_MAC_BASE + (ofs)) #define MT_PCIE_MAC_INT_ENABLE MT_PCIE_MAC(0x188) -- 2.25.1