Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1415870pxb; Fri, 26 Feb 2021 10:05:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJz/mjvfswzlloGMVgRAX/Nn1wo+NXZTQ9uJCU11pX3CY8zsIo1pCSEDaEewfjCWV9+JEnX9 X-Received: by 2002:a17:906:8043:: with SMTP id x3mr4572800ejw.149.1614362736224; Fri, 26 Feb 2021 10:05:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614362736; cv=none; d=google.com; s=arc-20160816; b=Fie+YnZRfn9SQJdWA3JiYwGKBfvAjbgNrFgWT9lDQA4+2H7pJLcxGMhCxDpq886KH2 dV1xllIwgxX04sL4J/zeYunt0T/X3/PwmoSfQXBmYnXEaqej47TVqIQzrBFKsmO5wTDL Kh6rknNxdeYertSDWm4MjI6PxwK+JmI/WYil1jCKuGt68Ys03rgQNJvJto1iZ6g0Cuoy ntJvktZeFMpocX+76/DqWWalwROQKi61pGWInTuCYZZLW4lOs/i91NTwwm51tDZEG5ni roVJosO1BazPVsDDtXz2++xEqAbl2HKE3Zyj1fHemns14AKFCpSZDyYvC2nfki5L8ZkA hZvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=3KyA0HiWZTKB1pCa3kqH8k87pwUWuQClFdJk/hCgRGI=; b=L1A6CJ/2I33IOIOGPJ+8aNt8QbX4op9bxV18IGodUBq8qSm/2iTgwRHcJ+geck/0gL /HDz6je1eQXi1a/cvjJiiZmAPRdXdC0oee0QRU/PMH/gSnXS4jH/0yLaej00yjrpx33a AdfGgD29ijYVVl8wh46bIGcj6xUsYVT7IT9zcj8wuP4XX/75qiEp3ofJrcBhiePgnrm2 LS8BPi286BmSA9Pp4GRVoKcCnpbSEF+iJc52tdzaxXeWZW0enUOeCJZZ+qSeVC2UyMg3 aIvV7NKwL+WtUdga1raNZqV7p//RXczejoVySNwvQ8I5DCAxCz22uTvoIJU381+5Tgb0 kf+w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f27si6426657ejf.555.2021.02.26.10.05.10; Fri, 26 Feb 2021 10:05:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230258AbhBZSEv (ORCPT + 99 others); Fri, 26 Feb 2021 13:04:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229949AbhBZSEl (ORCPT ); Fri, 26 Feb 2021 13:04:41 -0500 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97B37C061574; Fri, 26 Feb 2021 10:04:01 -0800 (PST) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1lFhSn-0091en-Ra; Fri, 26 Feb 2021 19:03:42 +0100 Message-ID: <4a997ea7b6625428c21dc3e423e96ee54d6785e2.camel@sipsolutions.net> Subject: Re: [PATCH v2 2/3] lockdep: add lockdep lock state defines From: Johannes Berg To: Shuah Khan , peterz@infradead.org, mingo@redhat.com, will@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 26 Feb 2021 19:03:40 +0100 In-Reply-To: (sfid-20210226_185441_806149_D5A42553) References: (sfid-20210226_185441_806149_D5A42553) Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org > @@ -5475,7 +5476,7 @@ noinstr int lock_is_held_type(const struct lockdep_map *lock, int read) > /* avoid false negative lockdep_assert_not_held() > * and lockdep_assert_held() > */ > - return -1; > + return LOCK_STATE_UNKNOWN; I'd argue that then the other two return places here should also be changed. johannes