Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1526726pxb; Fri, 26 Feb 2021 13:09:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJzH58a8rVvIL5fWpSFSOs+ACZDsCxhas6WqEQG4jDd8FHdTwugQEWFf05/HxPQD0LNCkKSO X-Received: by 2002:a17:906:72d1:: with SMTP id m17mr5377283ejl.118.1614373787561; Fri, 26 Feb 2021 13:09:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614373787; cv=none; d=google.com; s=arc-20160816; b=nxWIZkHh5Yokp6zocb27P7To13KgUE/YM1EFGzN5sAftDHmpWaAYUuPOHCfXBAY4Mp SIDu8H0TuYFiDL0rFANcPOzZxTckCLCnm4WCwPeRt08RRi39mcoLqZU43uK+bIuwYiMF p4GQWj56JeaMAdMD99PP36ilzB48noNa1+ebkFkUosLKNrcvxSotLpqVpPqQkKMwy2RS 8zEN+ehfL+uRmScc0kLk64i3NjpLZqe9PZVMhiC/kQj6IfIiz46Jm+I7om0+yJeMUhPI hubLoeWN/fMKrCr8r9sl0QDW05cnI0Q5I0VfrE4p6G797SIQOyFfAALqRvPTwsi1JR5r 2nlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=7pgftJoNP5KTdbInm9s0p3yXUSHbaaNN6wUdMbqk36Q=; b=GKs5OCun5pn1yMmsp45eFVrmd6tdUoobNEAtnQxU/yGS3KYHirQDFdw+mb8YwO7Inx u+TGa58e6mtHXhF0MWZJvs0+aiOtwogwpZI452UcL7bi/r4V1C/vN/LvwDH5iCQYoWZm /BClgJ3rxM/4es9cb8afgTZsksSUpvgQGsK/L45nYt5qSQcv/aFTNWM8znlhi/HyNqWw 4Hj4T3qmhOTlTF3lXUTQ2/TP/fob2WGR4ZllTSdvmuUfINba4EmgBr/SdN23r9wJr0RB yY+6SXVVLMjkQztbfL22CzSOiV90OzXXm8zY1sSpvvx/2WHDUyP4Gpa3jCVmEVPeFvjd xnFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=iiQ3KmXm; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t5si5500519ejy.248.2021.02.26.13.09.22; Fri, 26 Feb 2021 13:09:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=iiQ3KmXm; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230087AbhBZVIP (ORCPT + 99 others); Fri, 26 Feb 2021 16:08:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229990AbhBZVIO (ORCPT ); Fri, 26 Feb 2021 16:08:14 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C2D4C061756; Fri, 26 Feb 2021 13:07:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=7pgftJoNP5KTdbInm9s0p3yXUSHbaaNN6wUdMbqk36Q=; b=iiQ3KmXmdmtEz3zoxoZjCfxwfG jdd70ti+Bkd01AvEbuYEA93mZ5RxbcslWYlslLagJqUxLmTq+FY3f5Dx749FY5vIS0nlDP1hmce1V etaW4F0Qal/ZfdjqmAUKMzfF8mP3WKiH8C+gUzC0iGL2xb5PQT6vwGcnobN5nsC6VYTEf8jDCw3dj cCu9tOQwgTyuQf1oUE0XGJYPpyiU2taOff/CHWOi1cIuMkEOsfIVl38BoqmLKlw65QR+mYD9LrKDY wuBaYI2/HVpH3vgLMnUiWS31zzPWnFQBqMLDzOwbQKSYP3MclasDj9rSUtJvyQYrg2oNaOfZ7/rxe /S1kQXEQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lFkKI-00CVhR-Ph; Fri, 26 Feb 2021 21:07:08 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 2D6843006D0; Fri, 26 Feb 2021 22:07:04 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 1BDE720616380; Fri, 26 Feb 2021 22:07:04 +0100 (CET) Date: Fri, 26 Feb 2021 22:07:04 +0100 From: Peter Zijlstra To: Shuah Khan Cc: mingo@redhat.com, will@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org, ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] lockdep: add lockdep_assert_not_held() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Fri, Feb 26, 2021 at 10:52:13AM -0700, Shuah Khan wrote: > + /* avoid false negative lockdep_assert_not_held() > + * and lockdep_assert_held() > + */ That's a coding style fail.