Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1449698pxb; Thu, 4 Mar 2021 11:33:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJwvc5ZnX0YgniQrKbAp3SgI+swWrK1+K7a5qI+dlxh4foxMhNCx4Wiy8eExXwqM2kQqZhwz X-Received: by 2002:a17:906:7d7:: with SMTP id m23mr6099211ejc.205.1614886400457; Thu, 04 Mar 2021 11:33:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614886400; cv=none; d=google.com; s=arc-20160816; b=idTPvNiOW7Gwm1XXqADSSNs5EpTtgy0Hs6OFTUKtZChR4/g3kHHHYMRN2X0e5kewuZ fq02iMXfLHYc/2yozwa000F7Yvh7aG2u1QRBWTR6sSlq9xSIFMbg/B6i0hY3Awn4cjG0 ++QqGR2TMSxoiceldN5AC6FnhIp5J0pd/tuUCXcj0L3iaSmthcIFU8KF2WJJz7UWJ/jt /WkIdJjNSs9oZIogWEbWaYzw3IcDG3C51wpNzwmDnmmspK1I3OQ9sODj4q8p6Z7y5QI7 Do9ZKKxxVplzgUWme23C6jE3YXOujDpvOc1esVmjwuAVy1NcfWKpAP/3nRVucJTtd3KX 7mxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=7i8BEbXDXEOW8E286D5JURPRm2okvke1VJqD1R/Oop4=; b=KMFRE8JaMaObcj7KAO/mBQjS0JDoZRs3j7yxU8QtYymvge9DAQAguc5l4sQZGkHPE6 1poc8AiApfLVzze3gIkuNYKSDlzonQi8ZWJxHFJATNIMnn6XRV3jjkQimlFpAnhMou0K YZ3ezA+l13dsKLw6IVgZZKGi0cgfvrvc4iZ1wydWIf8mO5x3xvreNBGLpqdoIj9h7kxV cfYj33mOZDcqb2Q//4JpzsiSGvNmoAL8Y+dSHvBOgAP8gxsbPhgkjeEuArfqsb9VUqoU 3zf7jJYtKe65bDadZVb3aVy/2BCht7PS/sCkligGm0isZEJAVhWGHxpWkERPZdiAUlmb jIxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b="oy/Fil/c"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g6si232122edv.439.2021.03.04.11.32.53; Thu, 04 Mar 2021 11:33:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b="oy/Fil/c"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230207AbhCDT3z (ORCPT + 99 others); Thu, 4 Mar 2021 14:29:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230141AbhCDT3Y (ORCPT ); Thu, 4 Mar 2021 14:29:24 -0500 Received: from nbd.name (nbd.name [IPv6:2a01:4f8:221:3d45::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BCE2C061574 for ; Thu, 4 Mar 2021 11:28:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=7i8BEbXDXEOW8E286D5JURPRm2okvke1VJqD1R/Oop4=; b=oy/Fil/cXzLyBMkS+Zdzw/o5fK 7sS5AzQoGZaDuDZ6D64Xygfw5oTGh4GSRWmF89/lfkxKv/F1hUPpmUGjWIztDX8GAWjzeXLXee6gL o7RhOqlgUOIWMeDKc9nTWMOeIigFxyBXH20skz2mOiAbT7lM/NTykEzfYmWUcubbcLJ8=; Received: from p4ff13c8d.dip0.t-ipconnect.de ([79.241.60.141] helo=nf.local) by ds12 with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1lHtdy-0003kA-JI; Thu, 04 Mar 2021 20:28:18 +0100 Subject: Re: [PATCH v4] mt76: mt7615: add missing capabilities for DBDC To: Ryder Lee , Lorenzo Bianconi Cc: Shayne Chen , linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org References: <0573b06759c90309b5a6a6e2b6b95796e7db60c7.1614843966.git.ryder.lee@mediatek.com> From: Felix Fietkau Message-ID: <384dc2df-60d7-c6bf-040c-d8583af30a98@nbd.name> Date: Thu, 4 Mar 2021 20:28:17 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <0573b06759c90309b5a6a6e2b6b95796e7db60c7.1614843966.git.ryder.lee@mediatek.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2021-03-04 09:55, Ryder Lee wrote: > This improves performance for second phy. > > Signed-off-by: Ryder Lee I actually prefer v1 of this patch. You can fix the init order issues by simply dropping the if (phy->mt76->cap.has_*) checks, since they are not needed at all. - Felix