Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1581340pxb; Mon, 8 Mar 2021 00:46:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJztrGHljy/66wlCb5hLlqiNEVVluJBH3/FO+v5ewehcHQjURjm6yRNAPKBryflS5Yg2Pmey X-Received: by 2002:a17:906:8443:: with SMTP id e3mr13711986ejy.370.1615193171340; Mon, 08 Mar 2021 00:46:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615193171; cv=none; d=google.com; s=arc-20160816; b=IOI2wXl4J5uPrgGAxI6+0hPzI5LkLHW7tsJYfg1bXFfumFW+eYC5w8pB60eiGWrzoK ynoLKX9jpTsZ82WeXxDDX9E62njsghQZ2S4DdaImyaxcTcMsQD389d/dhdDLYcaEhr0T okiOGpPUKLndu7X5mwRuExaqd+jtF4mPpBEB9Ne7qDIYJsbLDX3O70chdioDnNCavjZR jyls08Mf7cihHEGIpfrJmhNK2KE3WQuHXEQSct817NP824dgIwzbpSR87WX5bItgrqfY t5wi0mQryZx/MjqwF2BLPiCOSmRUQEBeSbQ9jtBF8NhWkn+fdIeJmTy0xBJtb10jdm9m nlIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:message-id:references:in-reply-to :subject:cc:to:from:date:content-transfer-encoding:mime-version :sender:dkim-signature; bh=2zzNrDlFyq67/9T0xdtnfJBgqMfTjf8EjAqAeAeSK2s=; b=GawNCXxBKqtQ9LWYnRoA2PJc2HRA8ZKbHj8EjSPq+ajtUfM+W4jshhWd2bz7s5OEEC UKo2YFjOmd4+yB4M0rd8Iz6FmN7z8NLZj25toACGzHpMJRh2c7yilEGUfT/D/tKxge0Z /TX1/r7WWj1ALQE8/5MqVdo07KkfkRRz4PY3BRMTxjBMkqK4WkNUA9Kza5CgmzbN2B2U AsDdcjAqF1fwpTOAswDpeMdXLPAO6yk/Yq+hVTfZ4SUg0PEk1VBR95fumNeSMsEsghgc 5bkP9hPKV6crHfKdVVHiJCRWlMV/eIycsq0Iln5RQ5wWo0+2C+iRg3t6sePgxJqgSSxD 7W6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=rqWS4hL7; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m21si6474542ejx.725.2021.03.08.00.45.48; Mon, 08 Mar 2021 00:46:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=rqWS4hL7; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230192AbhCHHWo (ORCPT + 99 others); Mon, 8 Mar 2021 02:22:44 -0500 Received: from z11.mailgun.us ([104.130.96.11]:33938 "EHLO z11.mailgun.us" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229704AbhCHHWd (ORCPT ); Mon, 8 Mar 2021 02:22:33 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1615188153; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=2zzNrDlFyq67/9T0xdtnfJBgqMfTjf8EjAqAeAeSK2s=; b=rqWS4hL74JNaNGgJr1qqCF0Ktcufv9S2arl3Ip9ZVG2v2xNOpJtW+fBFL1+hqznB0P2yWm2h eWZ3KGgyESgxKoGdMTOGfwOFvHZ3bFJOP0xxGMf0jxjUzb0WWUF0iSzKPjipITsqen//tbwH +bBtjS7rHje+/VdEucVRqeLD1Pg= X-Mailgun-Sending-Ip: 104.130.96.11 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n07.prod.us-west-2.postgun.com with SMTP id 6045d0b0c862e1b9fd27e887 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 08 Mar 2021 07:22:24 GMT Sender: wgong=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 6C079C433C6; Mon, 8 Mar 2021 07:22:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: wgong) by smtp.codeaurora.org (Postfix) with ESMTPSA id B8447C433CA; Mon, 8 Mar 2021 07:22:23 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 08 Mar 2021 15:22:23 +0800 From: Wen Gong To: Steven Rostedt Cc: Brian Norris , ath10k , linux-wireless Subject: Re: [PATCH] ath10k: change len of trace_ath10k_log_dbg_dump for large buffer size In-Reply-To: <20210210115322.0b65a856@gandalf.local.home> References: <1612839593-2308-1-git-send-email-wgong@codeaurora.org> <20210209145531.5977b16d@gandalf.local.home> <20210209163431.11133472@gandalf.local.home> <9b479a88331dbf969f07708eabe53d14@codeaurora.org> <20210210113026.5f5ebe8a@gandalf.local.home> <20210210114823.1408dd64@gandalf.local.home> <20210210115322.0b65a856@gandalf.local.home> Message-ID: <137aaa6a6aa0ad0c0cf6e358705369c5@codeaurora.org> X-Sender: wgong@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2021-02-11 00:53, Steven Rostedt wrote: > On Wed, 10 Feb 2021 11:48:23 -0500 > Steven Rostedt wrote: > >> On Wed, 10 Feb 2021 11:30:26 -0500 >> Steven Rostedt wrote: >> >> > Can you test this patch? >> >> v2: > > Bah! > > v3: > > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c > index b79bcacdd6f9..90d7ade03499 100644 > --- a/kernel/trace/trace.c > +++ b/kernel/trace/trace.c > @@ -2739,7 +2739,7 @@ trace_event_buffer_lock_reserve(struct > trace_buffer **current_rb, > (entry = this_cpu_read(trace_buffered_event))) { > /* Try to use the per cpu buffer first */ > val = this_cpu_inc_return(trace_buffered_event_cnt); > - if (val == 1) { > + if ((len < (PAGE_SIZE - sizeof(*entry))) && val == 1) { > trace_event_setup(entry, type, trace_ctx); > entry->array[0] = len; > return entry; After apply this patch(https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/kernel/trace/trace.c?id=b220c049d5196dd94d992dd2dc8cba1a5e6123bf). It not crash again on my v4.19 kernel.