Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2384948pxb; Tue, 9 Mar 2021 00:47:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJw1GuDYB06kFV+MCw5aE/kvztiE9WrdiXTV4Hyr18YHSqcMa5ksynCQIWufb+yTm1+H9NGS X-Received: by 2002:a05:6402:5113:: with SMTP id m19mr2887879edd.78.1615279630067; Tue, 09 Mar 2021 00:47:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615279630; cv=none; d=google.com; s=arc-20160816; b=LMxmNCa+g1XaJuXJZvLqts37wvM6k1PWeaM/phePHqZ6QQpx2cqRqBVXy8An+KSzSa Jl+22W5kkJy709DBxPUfpufZQoCRbiovX1CYjHcqQ0lf6zV0NRtxFguXPEtEBWxcXb9x SVF0PpOHhJt0Ys34eawsJdgeOvDzSZK8ok9mijF2nVkj44L+ADGmDf0kSSAhLpuQby3e cuzP45ELWWic/gICKid/YH4GTSywOTdqIB88MG7vDTEPwzXawGLN6VVqhBYODc/ypj3E 12/6Jph61J8WFWHXFoKSAyNgM/tuDQNVdEyqgncgMDjFccA2DiEtV6nVUOfFIS7x4r5s MOCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:subject:cc:to:from:date:dkim-signature:dkim-signature :message-id; bh=yxUKUiZYjhibc7jZnuln+kQQPBZLvoc8TbB9cqh+HxU=; b=CczyFg1Ije47mMlvUlQH3ujEiRzs0TEtrZrUGQXAcekK5yhvplgdmHpjLeNjKLZQIK 22XI2gLKcXz1G67+pq6Z+TUtTvjLmsiB+pvp1rCVNhxnsgdD+3b5pquyFqi/oYLxMIX1 kZ3TmBhDd2lPyGOlDIM1F2W+dU6zkIut8wF684fhQU72HHQax3bGTeRPqKRwwL6NnoDZ SsDQpqzx/5UgetGBWg66Eqw3ZyYqEC+u+uhHrl3NN7mPcySgxysZ0kfBHvVvC2EGcrzT eP84s1UrT4FS/LDM1hLLjQeyG6xfQ5FjIMlSk7PI3WqbljO4Ez3osgwxmykd5JoT5eqj 1tYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=Q13IywTH; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o20si8886760eja.515.2021.03.09.00.46.48; Tue, 09 Mar 2021 00:47:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=Q13IywTH; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231308AbhCIIqS (ORCPT + 99 others); Tue, 9 Mar 2021 03:46:18 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:51468 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230033AbhCIIpp (ORCPT ); Tue, 9 Mar 2021 03:45:45 -0500 Message-Id: <20210309084242.516519290@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1615279543; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: references:references; bh=yxUKUiZYjhibc7jZnuln+kQQPBZLvoc8TbB9cqh+HxU=; b=Q13IywTH7EUDUibhBHMamY2qhFxsv/BDqx36OJXLf+7Q44Guho/PkLo0IhD0AdtPtW3qgp w2kiHcvR7sBVw/aZ3JReCRcyFZlRWt+SuCKHybxLuc74cDc7lHqC324UCJCpOcGS/6Ls3s EhLTpsZEXaaEpOv4GY29Z4ou0fNI46qQM53sAOcYIjcXC41/DofN4shGkNo11xWFYmku8q +BZPhCPyND4RWjOPYGSjy32KLewEu+5lxFmZiGGM1sxsVMolDqMJf1t6+tL1UQBvIrjFxT qbmqFBDlC15LlYGmVcptExHe0laWMEkGcVg5P6122ht1p6DN8f+ltdobyMZ1WQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1615279543; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: references:references; bh=yxUKUiZYjhibc7jZnuln+kQQPBZLvoc8TbB9cqh+HxU=; b=IP5NQTNugT2CYFrvO7b8n1tyL7nIbQVE2j1mpwhsV2gWriSLkZq1moytqMLibvtQWJzD46 ea56QlNhvi/NPHAg== Date: Tue, 09 Mar 2021 09:42:15 +0100 From: Thomas Gleixner To: LKML Cc: Frederic Weisbecker , Sebastian Andrzej Siewior , "Ahmed S. Darwish" , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Lorenzo Pieralisi , Rob Herring , Bjorn Helgaas , linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org, Peter Zijlstra , Denis Kirjanov , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, ath9k-devel@qca.qualcomm.com, Kalle Valo , linux-wireless@vger.kernel.org, Chas Williams <3chas3@gmail.com>, linux-atm-general@lists.sourceforge.net, Stefan Richter , linux1394-devel@lists.sourceforge.net Subject: [patch 12/14] PCI: hv: Use tasklet_disable_in_atomic() References: <20210309084203.995862150@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-transfer-encoding: 8-bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Sebastian Andrzej Siewior The hv_compose_msi_msg() callback in irq_chip::irq_compose_msi_msg is invoked via irq_chip_compose_msi_msg(), which itself is always invoked from atomic contexts from the guts of the interrupt core code. There is no way to change this w/o rewriting the whole driver, so use tasklet_disable_in_atomic() which allows to make tasklet_disable() sleepable once the remaining atomic users are addressed. Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: Thomas Gleixner Cc: "K. Y. Srinivasan" Cc: Haiyang Zhang Cc: Stephen Hemminger Cc: Wei Liu Cc: Lorenzo Pieralisi Cc: Rob Herring Cc: Bjorn Helgaas Cc: linux-hyperv@vger.kernel.org Cc: linux-pci@vger.kernel.org --- drivers/pci/controller/pci-hyperv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/pci/controller/pci-hyperv.c +++ b/drivers/pci/controller/pci-hyperv.c @@ -1458,7 +1458,7 @@ static void hv_compose_msi_msg(struct ir * Prevents hv_pci_onchannelcallback() from running concurrently * in the tasklet. */ - tasklet_disable(&channel->callback_event); + tasklet_disable_in_atomic(&channel->callback_event); /* * Since this function is called with IRQ locks held, can't