Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2435296pxb; Tue, 9 Mar 2021 02:25:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJyMzUvxLgbwgvLTx73BY0i/mgSTjxyNUfpXgmL6XlIbUYra0etY0zsAsk4Hom1keciYa/Lp X-Received: by 2002:a17:906:eb89:: with SMTP id mh9mr19891339ejb.122.1615285516506; Tue, 09 Mar 2021 02:25:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615285516; cv=none; d=google.com; s=arc-20160816; b=W2e/++y/gwNlOfliWOi0HWgalYP4LFP89HyMIAW68On8Bn2YzLfmFzLFR9ujaGFoK8 AQlYy9iJn9Q0BVlFf6ElmCzcF355gb7cgHlY7q+ip2hq3R4ROviY1l+WtxSN0AC67w7O CtYAEzCAxey1J4fWB2xJSr9tCY76iu14cSSXnwSYarBzkXMoGhgr/uLJ46Efw5C5NzTA JafvsiFLg87YZWKE0OyMwcGajzNaoVsMrk1kEFdAtRaeWEYj0TmSGunzpw7Z6OHOSp8F iy+qZuXp0+b9eQMiYt6ZyEeDr7wnKmo8vjUhJK/pxrBFAyMTXq+JXmeaPTX8/F0eXsIL x91w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dmarc-filter:sender :dkim-signature; bh=TjLNpjOkpU3NJvxqk+olVOnd639fxr8nX2GxYnA2gbk=; b=SpISGft91FKXXusia5JMANCidqE7Ot4Z1xHsuvBALtxzYpehWnh2EqLW0Y7W+iOPx6 hnSLQGow9TdQxwkLu1HJwZXtK068XI59v4fDHrK+A/TcYBBTVPqKsL+9fawr1CHUAR4v UfECqZvvYIKSV3btcOP77/8KnFzRElRGZ7K5EYtOmuSgofXuZs4v9w/Km+ch+GuZBdci 3wIXq63a/YO/6v7oxtTqVFe5SxEpUb4LDkdNk+Eg4S5VD4ihOm/T6YHdZJnlA6wx+XXJ WgMZwyUjosRQsP4FyRJcRFtOru4ULJb/QW34QONv9rVx0zFHgsc+GfM92RdXLzJkO6n4 vIoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=QL5t6IB9; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v18si8494747eju.671.2021.03.09.02.24.52; Tue, 09 Mar 2021 02:25:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=QL5t6IB9; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230343AbhCIKYO (ORCPT + 99 others); Tue, 9 Mar 2021 05:24:14 -0500 Received: from m42-2.mailgun.net ([69.72.42.2]:18622 "EHLO m42-2.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230183AbhCIKXz (ORCPT ); Tue, 9 Mar 2021 05:23:55 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1615285435; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=TjLNpjOkpU3NJvxqk+olVOnd639fxr8nX2GxYnA2gbk=; b=QL5t6IB9xVw5Zhii243B0h02mC/OoPe8hyo3j8zUvdzQSNzwF5VY8kLaxQrEKpOlzbYnpNxj c+Joe8TPQ2pCSQSj+vbmaoxWgTNdanH9n/ewlG7lVrQP52cLnMur1OLc/dPGU8TLksYXQR2m so0LDOyZ7NQhVu8+MK/d4Tic4jY= X-Mailgun-Sending-Ip: 69.72.42.2 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-west-2.postgun.com with SMTP id 60474c9be5eea4c43bd9e5fb (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 09 Mar 2021 10:23:23 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 57F1DC4346D; Tue, 9 Mar 2021 10:23:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id B5E8CC433CA; Tue, 9 Mar 2021 10:23:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B5E8CC433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Thomas Gleixner Cc: LKML , Frederic Weisbecker , Sebastian Andrzej Siewior , "Ahmed S. Darwish" , ath9k-devel@qca.qualcomm.com, "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Peter Zijlstra , Denis Kirjanov , Chas Williams <3chas3@gmail.com>, linux-atm-general@lists.sourceforge.net, "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Lorenzo Pieralisi , Rob Herring , Bjorn Helgaas , linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org, Stefan Richter , linux1394-devel@lists.sourceforge.net Subject: Re: [patch 10/14] ath9k: Use tasklet_disable_in_atomic() References: <20210309084203.995862150@linutronix.de> <20210309084242.313899703@linutronix.de> Date: Tue, 09 Mar 2021 12:23:14 +0200 In-Reply-To: <20210309084242.313899703@linutronix.de> (Thomas Gleixner's message of "Tue, 09 Mar 2021 09:42:13 +0100") Message-ID: <871rco1v8t.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Thomas Gleixner writes: > From: Sebastian Andrzej Siewior > > All callers of ath9k_beacon_ensure_primary_slot() are preemptible / > acquire a mutex except for this callchain: > > spin_lock_bh(&sc->sc_pcu_lock); > ath_complete_reset() > -> ath9k_calculate_summary_state() > -> ath9k_beacon_ensure_primary_slot() > > It's unclear how that can be distangled, so use tasklet_disable_in_atomic() > for now. This allows tasklet_disable() to become sleepable once the > remaining atomic users are cleaned up. > > Signed-off-by: Sebastian Andrzej Siewior > Signed-off-by: Thomas Gleixner > Cc: ath9k-devel@qca.qualcomm.com > Cc: Kalle Valo > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: linux-wireless@vger.kernel.org > Cc: netdev@vger.kernel.org > --- > drivers/net/wireless/ath/ath9k/beacon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I assume this goes via some other tree: Acked-by: Kalle Valo -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches