Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 13 Mar 2021 16:43:10 +0100 (CET)
From:   Jiri Kosina <jikos@kernel.org>
To:     Kalle Valo <kvalo@codeaurora.org>
cc:     Luca Coelho <luciano.coelho@intel.com>,
        Johannes Berg <johannes.berg@intel.com>,
        Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
        linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iwlwifi: Fix softirq/hardirq disabling in
 iwl_pcie_enqueue_hcmd()
In-Reply-To: <87h7lfbowr.fsf@tynnyri.adurom.net>
Message-ID: <nycvar.YFH.7.76.2103131642290.12405@cbobk.fhfr.pm>
References: <nycvar.YFH.7.76.2103021125430.12405@cbobk.fhfr.pm> <nycvar.YFH.7.76.2103080925230.12405@cbobk.fhfr.pm> <nycvar.YFH.7.76.2103130242460.12405@cbobk.fhfr.pm> <87h7lfbowr.fsf@tynnyri.adurom.net>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Sat, 13 Mar 2021, Kalle Valo wrote:

> >> > From: Jiri Kosina <jkosina@suse.cz>
> >> > 
> >> > It's possible for iwl_pcie_enqueue_hcmd() to be called with hard IRQs 
> >> > disabled (e.g. from LED core). We can't enable BHs in such a situation.
> >> > 
> >> > Turn the unconditional BH-enable/BH-disable code into 
> >> > hardirq-disable/conditional-enable.
> >> > 
> >> > This fixes the warning below.
> >> 
> >> Hi,
> >> 
> >> friendly ping on this one ... 
> >
> > Luca,
> >
> > Johannes is telling me that he merged this patch internally, but I have no 
> > idea what is happening to it ... ?
> >
> > The reported splat is a clear bug, so it should be fixed one way or the 
> > other.
> 
> Should I take this to wireless-drivers?

I can't speak for the maintainers, but as far as I am concerned, it 
definitely is a 5.12 material, as it fixes real scheduling bug.

Thanks,

-- 
Jiri Kosina
SUSE Labs