Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 022C3C433CA
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] rtw88: Fix an error code in rtw_debugfs_set_rsvd_page()
From:   Kalle Valo <kvalo@codeaurora.org>
In-Reply-To: <YCwgb/4F4Y+tyE56@mwanda>
References: <YCwgb/4F4Y+tyE56@mwanda>
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     Yan-Hsuan Chuang <tony0620emma@gmail.com>,
        Tzu-En Huang <tehuang@realtek.com>,
        linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2
Message-Id: <20210315080817.D04F3C43462@smtp.codeaurora.org>
Date:   Mon, 15 Mar 2021 08:08:17 +0000 (UTC)
Precedence: bulk

Dan Carpenter <dan.carpenter@oracle.com> wrote:

> The sscanf() function returns either 0 or 1 here.  It doesn't return
> error codes.  We should return -EINVAL if the string is invalid.
> 
> Fixes: c376c1fc87b7 ("rtw88: add h2c command in debugfs")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Why do you remove the num variable? I think the code is more readable with it.

(Sorry, I'm not able to quote the code as I'm replying from patchwork script
and it doesn't support that yet.)

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/YCwgb/4F4Y+tyE56@mwanda/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches