Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3111542pxf; Mon, 15 Mar 2021 01:24:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwhkqqLE5YXrvJOrkOPO+rdC2rzj3wr9ePUtCYMVGKGrURI3ag5TadeK/6KyL2e5TKAmkt6 X-Received: by 2002:a05:6402:2cd:: with SMTP id b13mr28648575edx.55.1615796690542; Mon, 15 Mar 2021 01:24:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615796690; cv=none; d=google.com; s=arc-20160816; b=WEx8t4kSrWbIo/lP/ZwWaq7uKD/vQ+7i42Smnh8/tK8RY5S/Rk8eHKJk/jD/n/1vPm Oa0U/8JVxxOZ8OzDxayD66chBUVzwNOXg44wsyZzy4g3AkAUC1rXV7HS5d0y4vVfGNNV LqS5wXwt3D6xKa9NEu7tzr+E0QzvuDCFmLyQJ5x81Yz0Y+4YZAih7Hy4Zvs/UyJa67uT EqllsBr3wB9K9DaE2zvBOB9ln1R3CNGtinp6rXSMF8RX83IsBjhrSpoiseiK506yBL8X YHSdCor9w49cB/bUaUTMroueDVRINDh/WK3FZpvu96arObaO1MO6nhy1AIz0fyZ1ebCr zlIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dmarc-filter:sender:dkim-signature; bh=egW71XUo1KXjfG19RKKEjftCPONENS0wYUPLTYAUT6o=; b=snYJKlywfGp9IARNmZPKKRcNU8hG3MhIyd6xitSjMN0xRcrA6iT+/AogsjHfp2POwW z2927lUx6gazsYVdQmfha55NpIxO1xeJKlKOMx/2ixWXfbd/+AYQybKegKy9BKsNY8vm OQ4w0M9hG3eF7B8WGV2jCy/Vxm64qb3j7hwzqF6HbVBYEYS/oC8+2hij1NxCP3w1Cegm JFUM3mMQXR/bzAWKM2qI1Y+aqmo5RpMSMO02/k+l5GPxs1qobWEIttIpqtuFsyOjC0Ux ZalGKVuLUNciTrvkpYRRYGD2M7idYnDZP+3ZT5IyE/3vJm6iLR1UZQvxdtrocBG+PSOP e4wA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=M+Dug7OS; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q19si9994255edv.55.2021.03.15.01.24.28; Mon, 15 Mar 2021 01:24:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=M+Dug7OS; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230198AbhCOIXz (ORCPT + 99 others); Mon, 15 Mar 2021 04:23:55 -0400 Received: from z11.mailgun.us ([104.130.96.11]:61193 "EHLO z11.mailgun.us" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229924AbhCOIXv (ORCPT ); Mon, 15 Mar 2021 04:23:51 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1615796631; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=egW71XUo1KXjfG19RKKEjftCPONENS0wYUPLTYAUT6o=; b=M+Dug7OSpeVPwnhkdrQvWcCD9GHH6KU+2bqhMm6Ji3wabEqyM0FTSseGa2EPiX23pWDl4VKn x3IdrMPRQrpF6B+jZiPNvNj8hHZKbWuGJDx1eTQgD/afTdOAF0ByOJClU764dSrb70znuDSM 8DWoChIvS+NWSnZzE7qyRdqiiQA= X-Mailgun-Sending-Ip: 104.130.96.11 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-west-2.postgun.com with SMTP id 604f198d5d70193f885a1637 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 15 Mar 2021 08:23:41 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id AF50BC433ED; Mon, 15 Mar 2021 08:23:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,BAYES_00, MISSING_DATE,MISSING_MID,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 3250BC433C6; Mon, 15 Mar 2021 08:23:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 3250BC433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] rtw88: remove unnecessary variable From: Kalle Valo In-Reply-To: <20210223075438.13676-1-samirweng1979@163.com> References: <20210223075438.13676-1-samirweng1979@163.com> To: samirweng1979 Cc: tony0620emma@gmail.com, davem@davemloft.net, kuba@kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, inux-kernel@vger.kernel.org, wengjianfeng User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20210315082341.AF50BC433ED@smtp.codeaurora.org> Date: Mon, 15 Mar 2021 08:23:41 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org samirweng1979 wrote: > From: wengjianfeng > > The variable ret is defined at the beginning and initialized > to 0 until the function returns ret, and the variable ret is > not reassigned.Therefore, we do not need to define the variable > ret, just return 0 directly at the end of the function. > > Signed-off-by: wengjianfeng Patch applied to wireless-drivers-next.git, thanks. 4a7ea94377c9 rtw88: remove unnecessary variable -- https://patchwork.kernel.org/project/linux-wireless/patch/20210223075438.13676-1-samirweng1979@163.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches