Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 15 Mar 2021 12:11:07 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Kalle Valo <kvalo@codeaurora.org>
Cc:     Yan-Hsuan Chuang <tony0620emma@gmail.com>,
        Tzu-En Huang <tehuang@realtek.com>,
        linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] rtw88: Fix an error code in rtw_debugfs_set_rsvd_page()
Message-ID: <20210315091107.GO21246@kadam>
References: <YCwgb/4F4Y+tyE56@mwanda>
 <20210315080817.A3975C43461@smtp.codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210315080817.A3975C43461@smtp.codeaurora.org>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Mon, Mar 15, 2021 at 08:08:17AM +0000, Kalle Valo wrote:
> Dan Carpenter <dan.carpenter@oracle.com> wrote:
> 
> > The sscanf() function returns either 0 or 1 here.  It doesn't return
> > error codes.  We should return -EINVAL if the string is invalid.
> > 
> > Fixes: c376c1fc87b7 ("rtw88: add h2c command in debugfs")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> Why do you remove the num variable? I think the code is more readable with it.
> 

The way I wrote it is slightly more normal (457 vs 333) and we don't use
"num" except for the one if statement.  But I can write the other way.
I'll resend.

regards,
dan carpenter