Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <0378ea17e0a8bdb72d635430ff14edc428591690.camel@gmail.com>
Subject: Re: SAE offload on brcmfmac (BCM4345)
From:   James Prestwood <prestwoj@gmail.com>
To:     "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Date:   Mon, 15 Mar 2021 10:46:56 -0700
In-Reply-To: <1262e6e9c7d2ab499c15a3d297ed87206e49711b.camel@gmail.com>
References: <1262e6e9c7d2ab499c15a3d297ed87206e49711b.camel@gmail.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

Maybe a simpler question: What brcmfmac cards *do* support SAE offload?
So far I have tried:

BCM4345 (raspberry pi 3 B+)
BCM43602
BCM43242

The last two are quite old (fw dated 2013/2015) so I wouldn't expect
those to work. According to the documentation the BCM4345 should
support SAE offload, but me and several others have tried checking the
extended features and it is not enabled.

Thanks,
James

On Thu, 2021-03-04 at 11:29 -0800, James Prestwood wrote:
> Hi,
> 
> I am trying to get SAE offload support on a BCM4345 (raspberry pi
> B+).
> From what I can tell it appears the Cypress firmware is not enabling
> the right bits. It looks like the brcmfmac driver has all the code to
> enable the extended feature. Here is what I have done so far:
> 
> Cloned raspi linux kernel v5.4
> 
> Downloaded latest Cypress firmware:
> https://community.cypress.com/t5/Resource-Library/Cypress-Linux-WiFi-Driver-Release-FMAC-2020-09-25/ta-p/251089
> 
> Applied the patches from above. Note not *all* the patches applied
> (could be due to already upstreamed), but most did. I did have to fix
> an include issue so brcmfmac/cfg80211.c could reference
> LINUX_CODE_VERSION/LINUX_VERSION.
> 
> Built new kernel/installed etc.
> 
> After that everything built, and I do see SAE offload source code
> which
> sets the ext feature if BRCMF_FEAT_SAE is enabled.
> 
> I see my new kernel here:
> 
> Linux raspberrypi 5.4.83-v7+ #2 SMP Thu Mar 4 10:54:16 PST 2021
> armv7l
> GNU/Linux
> 
> and dmesg shows the new firmware loading:
> 
> [    7.315275] brcmfmac: F1 signature read @0x18000000=0x15264345
> [    7.337608] brcmfmac: brcmf_fw_alloc_request: using
> brcm/brcmfmac43455-sdio for chip BCM4345/6
> [    7.338104] usbcore: registered new interface driver brcmfmac
> [    7.606184] brcmfmac: brcmf_fw_alloc_request: using
> brcm/brcmfmac43455-sdio for chip BCM4345/6
> [    7.616186] brcmfmac: brcmf_c_preinit_dcmds: Firmware: BCM4345/6
> wl0: Mar 23 2020 02:19:54 version 7.45.206 (r725000 CY) FWID 01-
> 88ee44ea
> 
> Yet iw does not have SAE_OFFLOAD set as an extended feature:
> 
> Supported extended features:
> 	* [ 4WAY_HANDSHAKE_STA_PSK ]: 4-way handshake with PSK in
> station mode
> 	* [ 4WAY_HANDSHAKE_STA_1X ]: 4-way handshake with 802.1X in
> station mode
> 	* [ DFS_OFFLOAD ]: DFS offload
> 
> Thanks,
> James
>